<p> Attention is currently required from: Jaco Kroon. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/20024">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/calendar.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/20024/comment/bc04c6d8_74cd83a4">Patch Set #2, Line 207:</a> <code style="font-family:monospace,monospace">const char* ast_calendar_busy_state_to_str(enum ast_calendar_busy_state busy_state);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There should be a space before the `*` and not after.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Additionally you should document the parameter and the return value.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_calendar.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/20024/comment/0cc836cc_d5f96706">Patch Set #2, Line 360:</a> <code style="font-family:monospace,monospace">const char* ast_calendar_busy_state_to_str(enum ast_calendar_busy_state busy_state)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There should be a space before the `*` and not after.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/20024/comment/6906e231_4ddcabf0">Patch Set #2, Line 369:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">default:<br>         return NULL;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">If `busy_state` can be something other than the 3 defined values I would argue that is a bug that should be fixed rather than papered over. Assuming it cannot be something unexpected than I feel an `ast_assert(0)` would be more appropriate than returning `NULL`.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/20024/comment/e9550103_a322f41f">Patch Set #2, Line 1700:</a> <code style="font-family:monospace,monospace">              ast_cli(a->fd, FORMAT2, "Busy State", ast_calendar_busy_state_to_str(event->busy_state) ?: "Unknown (Busy)");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If the above change is made then the ternary is not needed.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/20024">change 20024</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/20024"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I894e4ecc3e93db4ff7783d46266ba3c5e6ccda10 </div>
<div style="display:none"> Gerrit-Change-Number: 20024 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 23 Mar 2023 13:56:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>