<p> Attention is currently required from: N A, George Joseph. </p>
<p>Sean Bright would like N A, George Joseph and Friendly Automation to <strong>review</strong> this change.
</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/20007">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "pbx_ael: Global variables are not expanded."<br><br>This reverts commit c448dcd2f0e67acf527662574193994559ae853a.<br><br>Reason for revert: Behavior change that breaks existing dialplan.<br><br>ASTERISK-30472 #close<br><br>Change-Id: I20e44b4081d6ee0fe54cde44ac71dcf2d146f909<br>---<br>M res/ael/pval.c<br>1 file changed, 18 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/07/20007/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/ael/pval.c b/res/ael/pval.c</span><br><span>index 8596d66..10af159 100644</span><br><span>--- a/res/ael/pval.c</span><br><span>+++ b/res/ael/pval.c</span><br><span>@@ -4414,11 +4414,7 @@</span><br><span> {</span><br><span>        pval *p,*p2;</span><br><span>         struct ast_context *context;</span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef LOW_MEMORY</span><br><span>        char buf[2000];</span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(0, 100%, 40%);">-    char buf[8192];</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span>        struct ael_extension *exten;</span><br><span>         struct ael_extension *exten_list = 0;</span><br><span> </span><br><span>@@ -4431,13 +4427,9 @@</span><br><span>           case PV_GLOBALS:</span><br><span>                     /* just VARDEC elements */</span><br><span>                   for (p2=p->u1.list; p2; p2=p2->next) {</span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef STANDALONE</span><br><span style="color: hsl(0, 100%, 40%);">-                           snprintf(buf, sizeof(buf), "%s=%s", p2->u1.str, p2->u2.val);</span><br><span style="color: hsl(0, 100%, 40%);">-                            pbx_builtin_setvar(NULL, buf);</span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(0, 100%, 40%);">-                             pbx_substitute_variables_helper(NULL, p2->u2.val, buf, sizeof(buf) - 1);</span><br><span style="color: hsl(0, 100%, 40%);">-                             pbx_builtin_setvar_helper(NULL, p2->u1.str, buf);</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+                            char buf2[2000];</span><br><span style="color: hsl(120, 100%, 40%);">+                              snprintf(buf2,sizeof(buf2),"%s=%s", p2->u1.str, p2->u2.val);</span><br><span style="color: hsl(120, 100%, 40%);">+                          pbx_builtin_setvar(NULL, buf2);</span><br><span>                      }</span><br><span>                    break;</span><br><span>               default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/20007">change 20007</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/20007"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I20e44b4081d6ee0fe54cde44ac71dcf2d146f909 </div>
<div style="display:none"> Gerrit-Change-Number: 20007 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>