<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19602">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span></span><br></pre><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">func_callerid: Warn about invalid redirecting reason.<br><br>Currently, if a user attempts to set a Caller ID related<br>function to an invalid value, a warning is emitted,<br>except for when setting the redirecting reason.<br>We now emit a warning if we were unable to successfully<br>parse the user-provided reason.<br><br>ASTERISK-30332 #close<br><br>Change-Id: Ic341f5d5f7303b6f1115549be64db58a85944f5a<br>---<br>M funcs/func_callerid.c<br>1 file changed, 18 insertions(+), 0 deletions(-)<br><br></pre>
<pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/funcs/func_callerid.c b/funcs/func_callerid.c</span><br><span>index 64aeffc..448f546 100644</span><br><span>--- a/funcs/func_callerid.c</span><br><span>+++ b/funcs/func_callerid.c</span><br><span>@@ -1611,6 +1611,7 @@</span><br><span>                      * reason, so we can just set the reason string to what was given and set the</span><br><span>                         * code to be unknown</span><br><span>                         */</span><br><span style="color: hsl(120, 100%, 40%);">+                           ast_log(LOG_WARNING, "Unknown redirecting reason '%s', defaulting to unknown\n", val);</span><br><span>                             redirecting.orig_reason.code = AST_REDIRECTING_REASON_UNKNOWN;</span><br><span>                               redirecting.orig_reason.str = val;</span><br><span>                           set_it(chan, &redirecting, NULL);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19602">change 19602</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19602"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic341f5d5f7303b6f1115549be64db58a85944f5a </div>
<div style="display:none"> Gerrit-Change-Number: 19602 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>