<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19530">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span></span><br></pre><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">runUnittests.sh:  Save coredumps to proper directory<br><br>Fixed the specification of "outputdir" when calling ast_coredumper<br>so the txt files are saved in the correct place.<br><br>ASTERISK-30282<br><br>Change-Id: Ic631cb90c1e4c29d970c982dff45fda5e0eb15b6<br>---<br>M tests/CI/runUnittests.sh<br>1 file changed, 18 insertions(+), 4 deletions(-)<br><br></pre>
<pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/CI/runUnittests.sh b/tests/CI/runUnittests.sh</span><br><span>index e2d7e45..b929c54 100755</span><br><span>--- a/tests/CI/runUnittests.sh</span><br><span>+++ b/tests/CI/runUnittests.sh</span><br><span>@@ -52,7 +52,7 @@</span><br><span> </span><br><span> # If DESTDIR is used to install and run asterisk from non standard locations,</span><br><span> # the directory entries in asterisk.conf need to be munged to prepend DESTDIR.</span><br><span style="color: hsl(0, 100%, 40%);">-ALTERED=$(head -10 ../tmp/DESTDIR/etc/asterisk/asterisk.conf | grep -q "DESTDIR" && echo yes)</span><br><span style="color: hsl(120, 100%, 40%);">+ALTERED=$(head -10 "$ASTETCDIR/asterisk.conf" | grep -q "DESTDIR" && echo yes)</span><br><span> if [ x"$ALTERED" = x ] ; then</span><br><span>        # In the section that starts with [directories and ends with a blank line,</span><br><span>   # replace "=> " with "=> ${DESTDIR}"</span><br><span>@@ -119,7 +119,7 @@</span><br><span> fi</span><br><span> </span><br><span> # Cleanup "just in case"</span><br><span style="color: hsl(0, 100%, 40%);">-sudo killall -qe -ABRT $ASTERISK </span><br><span style="color: hsl(120, 100%, 40%);">+sudo killall -qe -ABRT $ASTERISK</span><br><span> </span><br><span> runner rsync -vaH $DESTDIR/var/log/asterisk/. $OUTPUTDIR</span><br><span> set +x</span><br><span>@@ -128,11 +128,11 @@</span><br><span> </span><br><span> for core in $(asterisk_corefile_glob)</span><br><span> do</span><br><span style="color: hsl(0, 100%, 40%);">-    if [ -f $core ]</span><br><span style="color: hsl(120, 100%, 40%);">+       if [ -f "$core" ] && [ "${core##*.}" != "txt" ]</span><br><span>        then</span><br><span>                 echo "*** Found a core file ($core) after running unit tests ***"</span><br><span>          set -x</span><br><span style="color: hsl(0, 100%, 40%);">-          sudo OUTPUTDIR=$OUTPUTDIR $DESTDIR/var/lib/asterisk/scripts/ast_coredumper --no-default-search $core</span><br><span style="color: hsl(120, 100%, 40%);">+          sudo $DESTDIR/var/lib/asterisk/scripts/ast_coredumper --outputdir=$OUTPUTDIR --no-default-search $core</span><br><span>       fi</span><br><span> done</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19530">change 19530</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19530"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic631cb90c1e4c29d970c982dff45fda5e0eb15b6 </div>
<div style="display:none"> Gerrit-Change-Number: 19530 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>