<p> Attention is currently required from: Michael Bradeen, George Joseph. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19413">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19413/comment/18cb8b35_ee1d47e0">Patch Set #3, Line 2283:</a> <code style="font-family:monospace,monospace">        pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "stateful response", 256, 256);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">where did the 256 come from?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19413/comment/7608ece3_2cd09d41">Patch Set #3, Line 2292:</a> <code style="font-family:monospace,monospace">  if(pj_grp_lock_create_w_handler(pool, NULL, pool, &pool_destroy_callback, &tsx_glock) != PJ_SUCCESS) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">if (</p><p style="white-space: pre-wrap; word-wrap: break-word;">what happens to the pool if this fails?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19413/comment/dfdd39f5_9a04836f">Patch Set #3, Line 2298:</a> <code style="font-family:monospace,monospace">        if(pj_grp_lock_add_ref(tsx_glock) != PJ_SUCCESS) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">if (</p><p style="white-space: pre-wrap; word-wrap: break-word;">what happens to the pool if this fails?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19413/comment/80097e7f_8d3f55ec">Patch Set #3, Line 2304:</a> <code style="font-family:monospace,monospace">            clean_contact_from_tdata(tdata);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">should the grp lock ref be decremented here? what happens to the pool?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19413">change 19413</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19413"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Id050fded2247a04d8f0fc5b8a2cf3e5482cb8cee </div>
<div style="display:none"> Gerrit-Change-Number: 19413 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 25 Oct 2022 12:31:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>