<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19413">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19413/comment/260b4219_5ee23623">Patch Set #1, Line 2288:</a> <code style="font-family:monospace,monospace">                clean_contact_from_tdata(tdata);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think this is a good idea. There's no way to know whether ast_sip_create_response was even called.  It should be up to the caller to clean up resources if they get an error response code.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Same for the cleanups below.</p><p style="white-space: pre-wrap; word-wrap: break-word;">In general I think cleaning up things you didn't allocate/lock/refcount isn't a good idea.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19413/comment/675f0e17_eba9571b">Patch Set #1, Line 2317:</a> <code style="font-family:monospace,monospace">     pj_grp_lock_dec_ref(tsx_glock);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not quite understanding.  If you decrement the lock here what was the whole point?  Is something happening while this function is being called?  Is that the "qualify" thread?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19413">change 19413</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19413"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Id050fded2247a04d8f0fc5b8a2cf3e5482cb8cee </div>
<div style="display:none"> Gerrit-Change-Number: 19413 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Oct 2022 13:48:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>