<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18965">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File tests/CI/runTestsuite.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18965/comment/5f03aa61_750a14d9">Patch Set #1, Line 15:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if [[ "$VIRTUAL_ENV" != "" ]]<br>then<br>            echo "Detected activated virtual environment:"<br>              echo $VIRTUAL_ENV<br>             echo "Skipping creation of new environment"<br>else<br>   python3 -m venv ${TESTSUITE_DIR}/.venv<br>        source ${TESTSUITE_DIR}/.venv/bin/activate<br>    if [[ "$VIRTUAL_ENV" != "" ]]<br>     then<br>          echo "Successfully activated virtual environment:"<br>          echo $VIRTUAL_ENV<br>             python -m pip install --upgrade pip<br>           python -m pip install wheel setuptools build<br>          python -m pip install -r ./requirements.txt<br>           python -m pip install -r ./extras.txt<br> else<br>          echo "Virtual environment failed, attempting fall-back method"<br>              export PYTHONPATH=./lib/python/<br>       fi<br>fi<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This logic should be placed in a top-level script in the testsuite (setup.sh maybe?) or directly in runtests.py.  With it here, you can't run the testsuite manually from the testsuite directory.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18965">change 18965</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18965"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I92ec7dec751ad455503a584d6e860db88c56d6bc </div>
<div style="display:none"> Gerrit-Change-Number: 18965 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 22 Aug 2022 10:33:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>