<p> Attention is currently required from: Alec Davis, Joshua Colp, N A. </p>
<p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18829">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829?tab=comments">Patch Set #7:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Try to use 'Redis' or 'redis' consistent in docs, comments, log output, etc. I do not see anything canonical that stylizes it as 'REDIS.'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/redisd.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/cacf43c6_aef477ed">Patch Set #7, Line 1:</a> <code style="font-family:monospace,monospace">[general]</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">For config files like this, I would prefer to see things lined up using all spaces instead of tabs.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/4f80a174_62b6663f">Patch Set #7, Line 6:</a> <code style="font-family:monospace,monospace">;dbname = 0 ; DB to select, default = 0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about 'database' or 'database_name?'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/5c1c404f_9e269131">Patch Set #7, Line 8:</a> <code style="font-family:monospace,monospace">bgsave = yes ; When set to yes, initiate a Background save when unloading module, default=no</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about 'background_save_on_unload?'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/redisd.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/2a715cf8_424d6559">Patch Set #7, Line 48:</a> <code style="font-family:monospace,monospace">AST_OPTIONAL_API(void, ast_redisd_command, (const char *command, const char *key_path, const char *key_value, char *return_buffer, size_t return_buffwe_len), {});</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I do not think this is good API for all of Asterisk (it only allows for a single Redis connection, for example).</p><p style="white-space: pre-wrap; word-wrap: break-word;">My suggestion would be to put the contents of res/res_redisd.c directly into res/res_redis_device_state.c and if someone wants to come along at a later time and create a general purpose Redis API they can.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_redis_device_state.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18829/comment/30d81c8e_acfa1b95">Patch Set #7, Line 88:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);<br> if (!device_state_sub) {<br> unload_module();<br> return AST_MODULE_LOAD_DECLINE;<br> }<br><br> stasis_subscription_accept_message_type(device_state_sub, ast_device_state_message_type());<br> stasis_subscription_set_filter(device_state_sub, STASIS_SUBSCRIPTION_FILTER_SELECTIVE);<br><br> return AST_MODULE_LOAD_SUCCESS;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Leading whitespace got a little funky here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18829">change 18829</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18829"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a </div>
<div style="display:none"> Gerrit-Change-Number: 18829 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 24 Jul 2022 15:18:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>