<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18828">View Change</a></p><p>14 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828?tab=comments">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks for the feedback</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/redisd.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/73d91911_8328f64d">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">[general]</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The sample config is a little sparse, though maybe there isn't really much to say. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/redisd.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/db4e41d9_672cf4d7">Patch Set #1, Line 6:</a> <code style="font-family:monospace,monospace"> * David M. Lee, II <dlee@digium.com></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Copyright looks wrong? Is this file really his or yours?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_redis_device_state.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/2e4f1600_7abf98fd">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> * Copyright (C) 2005-2006, Digium, Inc.</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Remove this - copyright is yours not Digium's</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/056cd48a_b2b01624">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace"> //throw away result</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Use /* comments */ only. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/46b37d89_67eca4b0">Patch Set #1, Line 81:</a> <code style="font-family:monospace,monospace"> char return_buffer[4096];</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Did you compile in developer mode? Mixed variables and declarations are *not* permitted.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">no, never used it before, and that's been many commits to asterisk.</p><p style="white-space: pre-wrap; word-wrap: break-word;">so I should be using ./configure --enable-dev-mode ?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_redisd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/bff11df5_733917d3">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> * Copyright (C) 2005-2006, Digium, Inc.</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Remove this. The copyright is yours, not Digium's.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/a90093e9_dec93fc9">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace"> *</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">formatting seems messed up here?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/644ed7d6_02765ee8">Patch Set #1, Line 47:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It seems like you're using spaces everywhere, not tabs. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/a1dd82e6_14821a3e">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace"> <synopsis>Global configuration settings</synopsis></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">For modules that have default options, explicitly specify them here using the appropriate XML attrib […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/4e1a9058_f395349a">Patch Set #1, Line 139:</a> <code style="font-family:monospace,monospace"> if (redisd_context == NULL) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You could just do !redisd_context</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Was following example.c on redis example.<br>https://github.com/redis/hiredis/blob/master/examples/example.c</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/dc249134_e2618473">Patch Set #1, Line 168:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_DEBUG, "Authenticated.\n");</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Use ast_debug(level, fmt, ...) not ast_log(LOG_DEBUG, fmt, ... […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/06ba157e_d49bc66c">Patch Set #1, Line 248:</a> <code style="font-family:monospace,monospace"> </code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">redness (trailing whitespace)</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18828/comment/d1e2e50d_17b973f0">Patch Set #1, Line 305:</a> <code style="font-family:monospace,monospace"> </code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">redness</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18828">change 18828</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18828"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I17dc11b1d0b4d046a3f092ddf7778108dbcd1cce </div>
<div style="display:none"> Gerrit-Change-Number: 18828 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alec Davis <alec@bdt.co.nz> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Jul 2022 22:25:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>