<p> Attention is currently required from: Michael Bradeen, George Joseph. </p>
<p>Patch set 12:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/18528">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528/comment/0aca8f08_beeff9d9">Patch Set #12, Line 9:</a> <code style="font-family:monospace,monospace">Multiple changes for compatibility. Requires latest version of all</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This commit message needs a clean up as it's actually two meshed together.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File contrib/scripts/install_prereq:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528/comment/df457fe6_4055796e">Patch Set #12, Line 269:</a> <code style="font-family:monospace,monospace"> echo "Testsuite requires python version >= 3.8"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this be 3.6.8?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File lib/python/asterisk/extension_bank.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528/comment/6be9fc3d_383a71f0">Patch Set #12, Line 2:</a> <code style="font-family:monospace,monospace">Copyright (C) 2022, Sangoma Corp</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Sangoma Technologies Corporation</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File lib/python/asterisk/pcap.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528/comment/c7efcd74_a92ddda3">Patch Set #12, Line 712:</a> <code style="font-family:monospace,monospace"> #interpreted_packet = self._packet_factories.SIPPacketFactory.interpret_packet(packet)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this just be removed? Is it no longer needed?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File runtests.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528/comment/87ef73fe_e6e9f120">Patch Set #12, Line 72:</a> <code style="font-family:monospace,monospace">#ast_config = test_suite_utils.get_asterisk_conf()</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What's the story of the change here?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File tests/rest_api/chunked-transfer/run-test:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528/comment/9c665fb8_2fb44c95">Patch Set #12, Line 35:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can be removed</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/18528/comment/0d81d04a_c7ef596f">Patch Set #12, Line 67:</a> <code style="font-family:monospace,monospace"># data=bytes(chunkizer(b"{ b'variable': b'foo', b'value': b'bar'' }"),"utf-8"),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can be removed</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/18528">change 18528</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/18528"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: development/16/python3 </div>
<div style="display:none"> Gerrit-Change-Id: I55caad3cb2a156b8e3f2f24dd10db5ebe67910d2 </div>
<div style="display:none"> Gerrit-Change-Number: 18528 </div>
<div style="display:none"> Gerrit-PatchSet: 12 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-CC: Mark Petersen <bugs.digium.com@zombie.dk> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 22 Jun 2022 10:51:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>