<p>Kevin Harwell has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18610">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">test_aeap_transport: disable part of failing unit test<br><br>The 'transport_binary' test sporadically fails, but on a theory that the<br>problem is caused by a previously executed test, transport_connect_fail,<br>part of that test has been disabled until a solution is found.<br><br>ASTERISK_30099<br><br>Change-Id: I48ed74d696aa9b6159f59661f3d535cac4c909e1<br>---<br>M tests/test_aeap_transport.c<br>1 file changed, 13 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/18610/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/test_aeap_transport.c b/tests/test_aeap_transport.c</span><br><span>index 675ecf2..e864d44 100644</span><br><span>--- a/tests/test_aeap_transport.c</span><br><span>+++ b/tests/test_aeap_transport.c</span><br><span>@@ -134,15 +134,22 @@</span><br><span> </span><br><span> ast_test_validate(test, !aeap_transport_is_connected(transport));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- aeap_transport_destroy(transport);</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * The following section of code has been disabled as it may be the cause</span><br><span style="color: hsl(120, 100%, 40%);">+ * of subsequent test failures.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * See ASTERISK-30099 for more information</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Test invalid protocol */</span><br><span style="color: hsl(0, 100%, 40%);">- ast_test_validate(test, (transport = aeap_transport_create(TRANSPORT_URL)));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* aeap_transport_destroy(transport); */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_test_validate(test, aeap_transport_connect(transport,</span><br><span style="color: hsl(0, 100%, 40%);">- TRANSPORT_URL, TRANSPORT_PROTOCOL_INVALID, TRANSPORT_TIMEOUT));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* /\* Test invalid protocol *\/ */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* ast_test_validate(test, (transport = aeap_transport_create(TRANSPORT_URL))); */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_test_validate(test, !aeap_transport_is_connected(transport));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* ast_test_validate(test, aeap_transport_connect(transport, */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TRANSPORT_URL, TRANSPORT_PROTOCOL_INVALID, TRANSPORT_TIMEOUT)); */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* ast_test_validate(test, !aeap_transport_is_connected(transport)); */</span><br><span> </span><br><span> return AST_TEST_PASS;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18610">change 18610</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18610"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I48ed74d696aa9b6159f59661f3d535cac4c909e1 </div>
<div style="display:none"> Gerrit-Change-Number: 18610 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>