<p>Kevin Harwell <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18428">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  George Joseph: Looks good to me, approved
  N A: Looks good to me, but someone else must approve
  Kevin Harwell: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">manager: Terminate session on write error.<br><br>On a write error to an AMI session a flag was set to<br>indicate that the write error had occurred, with the<br>expected result being that the session be terminated.<br>This was not actually happening and instead writing<br>would continue to be attempted.<br><br>This change adds a check for the write error and causes<br>the session to actually terminate.<br><br>ASTERISK-29948<br><br>Change-Id: Icaf5d413d4c0d5dc78292a17287fecc8720a31a5<br>---<br>M main/manager.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/manager.c b/main/manager.c</span><br><span>index 76a6611..4c55823 100644</span><br><span>--- a/main/manager.c</span><br><span>+++ b/main/manager.c</span><br><span>@@ -6242,7 +6242,7 @@</span><br><span>                       (s->session->readperm & eqe->category) == eqe->category &&</span><br><span>                           (s->session->send_events & eqe->category) == eqe->category) {</span><br><span>                                    if (match_filter(s, eqe->eventdata)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                               if (send_string(s, eqe->eventdata) < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                                         if (send_string(s, eqe->eventdata) < 0 || s->write_error)</span><br><span>                                                   ret = -1;       /* don't send more */</span><br><span>                                    }</span><br><span>                    }</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18428">change 18428</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18428"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icaf5d413d4c0d5dc78292a17287fecc8720a31a5 </div>
<div style="display:none"> Gerrit-Change-Number: 18428 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>