<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18039">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve
Kevin Harwell: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">documentation: Adds missing default attributes.<br><br>The configObject tag contains a default attribute which<br>allows the default value to be specified, if applicable.<br>This allows for the default value to show up specially on<br>the wiki in a way that is clear to users.<br><br>There are a couple places in the tree where default values<br>are included in the description as opposed to as attributes,<br>which means these can't be parsed specially for the wiki.<br>These are changed to use the attribute instead of being<br>included in the text description.<br><br>ASTERISK-29898 #close<br><br>Change-Id: I9d7ea08f50075f41459ea7b76654906b674ec755<br>---<br>M main/cdr.c<br>M res/res_ari.c<br>M res/res_pjsip.c<br>3 files changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/cdr.c b/main/cdr.c</span><br><span>index 8a3ad66..b059082 100644</span><br><span>--- a/main/cdr.c</span><br><span>+++ b/main/cdr.c</span><br><span>@@ -90,18 +90,18 @@</span><br><span> of use when debugging CDR behavior.</para></span><br><span> </description></span><br><span> </configOption></span><br><span style="color: hsl(0, 100%, 40%);">- <configOption name="enable"></span><br><span style="color: hsl(120, 100%, 40%);">+ <configOption name="enable" default="yes"></span><br><span> <synopsis>Enable/disable CDR logging.</synopsis></span><br><span> <description><para>Define whether or not to use CDR logging. Setting this to "no" will override</span><br><span style="color: hsl(0, 100%, 40%);">- any loading of backend CDR modules. Default is "yes".</para></span><br><span style="color: hsl(120, 100%, 40%);">+ any loading of backend CDR modules.</para></span><br><span> </description></span><br><span> </configOption></span><br><span style="color: hsl(0, 100%, 40%);">- <configOption name="channeldefaultenabled"></span><br><span style="color: hsl(120, 100%, 40%);">+ <configOption name="channeldefaultenabled" default="yes"></span><br><span> <synopsis>Whether CDR is enabled on a channel by default</synopsis></span><br><span> <description><para>Define whether or not CDR should be enabled on a channel by default.</span><br><span> Setting this to "yes" will enable CDR on every channel unless it is explicitly disabled.</span><br><span> Setting this to "no" will disable CDR on every channel unless it is explicitly enabled.</span><br><span style="color: hsl(0, 100%, 40%);">- Default is "yes".</para></span><br><span style="color: hsl(120, 100%, 40%);">+ </para></span><br><span> <para>Note that CDR must still be globally enabled (<literal>enable = yes</literal>) for this</span><br><span> option to have any effect. This only applies to whether CDR is enabled or disabled on</span><br><span> newly created channels, which can be changed in the dialplan during a call.</para></span><br><span>diff --git a/res/res_ari.c b/res/res_ari.c</span><br><span>index e8d1fee..025fa90 100644</span><br><span>--- a/res/res_ari.c</span><br><span>+++ b/res/res_ari.c</span><br><span>@@ -96,12 +96,12 @@</span><br><span> <ref type="link">https://wiki.asterisk.org/wiki/display/AST/Asterisk+Builtin+mini-HTTP+Server</ref></span><br><span> </see-also></span><br><span> </configOption></span><br><span style="color: hsl(0, 100%, 40%);">- <configOption name="websocket_write_timeout"></span><br><span style="color: hsl(120, 100%, 40%);">+ <configOption name="websocket_write_timeout" default="100"></span><br><span> <synopsis>The timeout (in milliseconds) to set on WebSocket connections.</synopsis></span><br><span> <description></span><br><span> <para>If a websocket connection accepts input slowly, the timeout</span><br><span> for writes to it can be increased to keep it from being disconnected.</span><br><span style="color: hsl(0, 100%, 40%);">- Value is in milliseconds; default is 100 ms.</para></span><br><span style="color: hsl(120, 100%, 40%);">+ Value is in milliseconds.</para></span><br><span> </description></span><br><span> </configOption></span><br><span> <configOption name="pretty"></span><br><span>diff --git a/res/res_pjsip.c b/res/res_pjsip.c</span><br><span>index 0ef2030..3d1f68c 100644</span><br><span>--- a/res/res_pjsip.c</span><br><span>+++ b/res/res_pjsip.c</span><br><span>@@ -1795,12 +1795,12 @@</span><br><span> or the <replaceable>wss</replaceable> protocols.</para></note></span><br><span> </description></span><br><span> </configOption></span><br><span style="color: hsl(0, 100%, 40%);">- <configOption name="websocket_write_timeout"></span><br><span style="color: hsl(120, 100%, 40%);">+ <configOption name="websocket_write_timeout" default="100"></span><br><span> <synopsis>The timeout (in milliseconds) to set on WebSocket connections.</synopsis></span><br><span> <description></span><br><span> <para>If a websocket connection accepts input slowly, the timeout</span><br><span> for writes to it can be increased to keep it from being disconnected.</span><br><span style="color: hsl(0, 100%, 40%);">- Value is in milliseconds; default is 100 ms.</para></span><br><span style="color: hsl(120, 100%, 40%);">+ Value is in milliseconds.</para></span><br><span> </description></span><br><span> </configOption></span><br><span> <configOption name="allow_reload" default="no"></span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18039">change 18039</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18039"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I9d7ea08f50075f41459ea7b76654906b674ec755 </div>
<div style="display:none"> Gerrit-Change-Number: 18039 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>