<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17929">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">func_frame_drop: Fix typo referencing wrong buffer<br><br>In order to get around the issue of certain frames<br>having names that could overlap, func_frame_drop<br>surrounds names with commas for the purposes of<br>comparison.<br><br>The buffer is allocated and printed to properly,<br>but the original buffer is used for comparison.<br>In most cases, this wouldn't have had any effect,<br>but that was not the intention behind the buffer.<br>This updates the code to reference the modified<br>buffer instead.<br><br>ASTERISK-29854 #close<br><br>Change-Id: I430b52e14e712d0e62a23aa3b5644fe958b684a7<br>---<br>M funcs/func_frame_drop.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/funcs/func_frame_drop.c b/funcs/func_frame_drop.c</span><br><span>index 5aa66df..c19c566 100644</span><br><span>--- a/funcs/func_frame_drop.c</span><br><span>+++ b/funcs/func_frame_drop.c</span><br><span>@@ -227,13 +227,13 @@</span><br><span>        buffer = ast_malloc(sizeof(value) + 3); /* leading and trailing comma and null terminator */</span><br><span>         snprintf(buffer, sizeof(value) + 2, ",%s,", value);</span><br><span>        for (i = 0; i < ARRAY_LEN(frametype2str); i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-             if (strcasestr(value, frametype2str[i].str)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                if (strcasestr(buffer, frametype2str[i].str)) {</span><br><span>                      framedata->values[i] = 1;</span><br><span>                 }</span><br><span>    }</span><br><span> </span><br><span>        for (i = 0; i < ARRAY_LEN(controlframetype2str); i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-              if (strcasestr(value, controlframetype2str[i].str)) {</span><br><span style="color: hsl(120, 100%, 40%);">+         if (strcasestr(buffer, controlframetype2str[i].str)) {</span><br><span>                       framedata->controlvalues[i] = 1;</span><br><span>          }</span><br><span>    }</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17929">change 17929</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17929"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I430b52e14e712d0e62a23aa3b5644fe958b684a7 </div>
<div style="display:none"> Gerrit-Change-Number: 17929 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>