<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17890">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_rtp_asterisk: Fix typo in flag test/set<br><br>The code currently checks to see if an RFC3389<br>warning flag is set, except if it is, it merely<br>sets the flag again, the logic of which doesn't<br>make any sense.<br><br>This adjusts the if comparison to check if the<br>flag has NOT been set, and if so, emit a notice<br>log event and set the flag so that future frames<br>do not cause an event to be logged.<br><br>ASTERISK-29856 #close<br><br>Change-Id: Ib7098c947c63537d087a03b4646199fbb963f8e1<br>---<br>M res/res_rtp_asterisk.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c</span><br><span>index 5fdcefe..7024081 100644</span><br><span>--- a/res/res_rtp_asterisk.c</span><br><span>+++ b/res/res_rtp_asterisk.c</span><br><span>@@ -5757,7 +5757,7 @@</span><br><span>                  ast_format_get_name(rtp->lastrxformat), len);</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (ast_test_flag(rtp, FLAG_3389_WARNING)) {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!ast_test_flag(rtp, FLAG_3389_WARNING)) {</span><br><span>                struct ast_sockaddr remote_address = { {0,} };</span><br><span> </span><br><span>           ast_rtp_instance_get_remote_address(instance, &remote_address);</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17890">change 17890</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17890"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 19 </div>
<div style="display:none"> Gerrit-Change-Id: Ib7098c947c63537d087a03b4646199fbb963f8e1 </div>
<div style="display:none"> Gerrit-Change-Number: 17890 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>