<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17512">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Kevin Harwell: Looks good to me, but someone else must approve
Benjamin Keith Ford: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res: Fix for Doxygen.<br><br>These are the remaining issues found in /res.<br><br>ASTERISK-29761<br><br>Change-Id: I572e6019c422780dde5ce8448b6c85c77af6046d<br>---<br>M include/asterisk/calendar.h<br>M include/asterisk/http_websocket.h<br>M include/asterisk/phoneprov.h<br>M include/asterisk/res_hep.h<br>M include/asterisk/res_mwi_external.h<br>M include/asterisk/res_pjproject.h<br>M include/asterisk/res_pjsip.h<br>M include/asterisk/res_pjsip_cli.h<br>M include/asterisk/statsd.h<br>M res/ael/ael_lex.c<br>M res/res_chan_stats.c<br>M res/res_config_ldap.c<br>M res/res_config_sqlite3.c<br>M res/res_crypto.c<br>M res/res_hep.c<br>M res/res_http_websocket.c<br>M res/res_monitor.c<br>M res/res_mwi_external.c<br>M res/res_phoneprov.c<br>M res/res_pjsip/pjsip_resolver.c<br>M res/res_pjsip_history.c<br>M res/res_pjsip_mwi.c<br>M res/res_pjsip_notify.c<br>M res/res_pjsip_session.c<br>M res/res_rtp_asterisk.c<br>M res/res_stasis.c<br>M res/res_stir_shaken/certificate.h<br>M res/res_stir_shaken/curl.c<br>M res/res_stun_monitor.c<br>M res/res_xmpp.c<br>M res/snmp/agent.h<br>M res/stasis/app.h<br>32 files changed, 104 insertions(+), 147 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/asterisk/calendar.h b/include/asterisk/calendar.h</span><br><span>index 9f89f33..4564c34 100644</span><br><span>--- a/include/asterisk/calendar.h</span><br><span>+++ b/include/asterisk/calendar.h</span><br><span>@@ -152,9 +152,6 @@</span><br><span> /*! \brief Unregister a new calendar technology</span><br><span> *</span><br><span> * \param tech calendar technology to unregister</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval 0 success</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval -1 failure</span><br><span> */</span><br><span> void ast_calendar_unregister(struct ast_calendar_tech *tech);</span><br><span> </span><br><span>diff --git a/include/asterisk/http_websocket.h b/include/asterisk/http_websocket.h</span><br><span>index d5489fa..2a55e60 100644</span><br><span>--- a/include/asterisk/http_websocket.h</span><br><span>+++ b/include/asterisk/http_websocket.h</span><br><span>@@ -127,10 +127,10 @@</span><br><span> };</span><br><span> </span><br><span> /*!</span><br><span style="color: hsl(0, 100%, 40%);">- * \brief Creates a \ref websocket_server</span><br><span style="color: hsl(120, 100%, 40%);">+ * \brief Creates a \ref ast_websocket_server</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval New \ref websocket_server instance</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval \c NULL on error</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return New \ref ast_websocket_server instance</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval NULL on error</span><br><span> * \since 12</span><br><span> */</span><br><span> AST_OPTIONAL_API(struct ast_websocket_server *, ast_websocket_server_create, (void), { return NULL; });</span><br><span>@@ -146,7 +146,7 @@</span><br><span> /*!</span><br><span> * \brief Allocate a websocket sub-protocol instance</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval An instance of \ref ast_websocket_protocol on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return An instance of \ref ast_websocket_protocol on success</span><br><span> * \retval NULL on error</span><br><span> * \since 13.5.0</span><br><span> */</span><br><span>@@ -169,7 +169,7 @@</span><br><span> * \param protocol The sub-protocol to register. Note that this must</span><br><span> * be allocated using /ref ast_websocket_sub_protocol_alloc.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \note This method is reference stealing. It will steal the reference to \ref protocol</span><br><span style="color: hsl(120, 100%, 40%);">+ * \note This method is reference stealing. It will steal the reference to \p protocol</span><br><span> * on success.</span><br><span> *</span><br><span> * \retval 0 success</span><br><span>@@ -192,6 +192,7 @@</span><br><span> /*!</span><br><span> * \brief Add a sub-protocol handler to the given server.</span><br><span> *</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param server The server to add the sub-protocol to</span><br><span> * \param name Name of the sub-protocol to register</span><br><span> * \param callback Callback called when a new connection requesting the sub-protocol is established</span><br><span> *</span><br><span>@@ -208,7 +209,7 @@</span><br><span> * \param protocol The sub-protocol to register. Note that this must</span><br><span> * be allocated using /ref ast_websocket_sub_protocol_alloc.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \note This method is reference stealing. It will steal the reference to \ref protocol</span><br><span style="color: hsl(120, 100%, 40%);">+ * \note This method is reference stealing. It will steal the reference to \p protocol</span><br><span> * on success.</span><br><span> *</span><br><span> * \retval 0 success</span><br><span>@@ -220,6 +221,7 @@</span><br><span> /*!</span><br><span> * \brief Remove a sub-protocol handler from the given server.</span><br><span> *</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param server The server to unregister the sub-protocol from</span><br><span> * \param name Name of the sub-protocol to unregister</span><br><span> * \param callback Callback that was previously registered with the sub-protocol</span><br><span> *</span><br><span>@@ -253,7 +255,7 @@</span><br><span> * \param ws pointer to the websocket</span><br><span> * \param buf string buffer to populate with data read from socket</span><br><span> * \retval -1 on error</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval number of bytes read on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return number of bytes read on success</span><br><span> *</span><br><span> * \note Once an AST_WEBSOCKET_OPCODE_CLOSE opcode is received the socket will be closed</span><br><span> */</span><br><span>@@ -332,7 +334,7 @@</span><br><span> /*!</span><br><span> * \brief Get the file descriptor for a WebSocket session.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval file descriptor</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return file descriptor</span><br><span> *</span><br><span> * \note You must *not* directly read from or write to this file descriptor. It should only be used for polling.</span><br><span> */</span><br><span>@@ -355,14 +357,14 @@</span><br><span> /*!</span><br><span> * \brief Get the remote address for a WebSocket connected session.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval ast_sockaddr Remote address</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return Remote address</span><br><span> */</span><br><span> AST_OPTIONAL_API(struct ast_sockaddr *, ast_websocket_remote_address, (struct ast_websocket *session), {return NULL;});</span><br><span> </span><br><span> /*!</span><br><span> * \brief Get the local address for a WebSocket connection session.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval ast_sockaddr Local address</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return Local address</span><br><span> *</span><br><span> * \since 13.19.0</span><br><span> */</span><br><span>@@ -387,7 +389,7 @@</span><br><span> /*!</span><br><span> * \brief Get the session ID for a WebSocket session.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval session id</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return session id</span><br><span> */</span><br><span> AST_OPTIONAL_API(const char *, ast_websocket_session_id, (struct ast_websocket *session), { errno = ENOSYS; return NULL;});</span><br><span> </span><br><span>@@ -414,21 +416,22 @@</span><br><span> /*!</span><br><span> * \brief Create, and connect, a websocket client.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \detail If the client websocket successfully connects, then the accepted protocol</span><br><span style="color: hsl(0, 100%, 40%);">- * can be checked via a call to ast_websocket_client_accept_protocol.</span><br><span style="color: hsl(120, 100%, 40%);">+ * If the client websocket successfully connects, then the accepted protocol can be</span><br><span style="color: hsl(120, 100%, 40%);">+ * checked via a call to ast_websocket_client_accept_protocol.</span><br><span> *</span><br><span> * \note While connecting this *will* block until a response is</span><br><span> * received from the remote host.</span><br><span style="color: hsl(0, 100%, 40%);">- * \note Expected uri form: ws[s]://<address>[:port][/<path>] The address (can be a</span><br><span style="color: hsl(0, 100%, 40%);">- * host name) and port are parsed out and used to connect to the remote server.</span><br><span style="color: hsl(0, 100%, 40%);">- * If multiple IPs are returned during address resolution then the first one is</span><br><span style="color: hsl(0, 100%, 40%);">- * chosen.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \note Expected uri form:</span><br><span style="color: hsl(120, 100%, 40%);">+ * \verbatim ws[s]://<address>[:port][/<path>] \endverbatim</span><br><span style="color: hsl(120, 100%, 40%);">+ * The address (can be a host name) and port are parsed out and used to connect</span><br><span style="color: hsl(120, 100%, 40%);">+ * to the remote server. If multiple IPs are returned during address</span><br><span style="color: hsl(120, 100%, 40%);">+ * resolution then the first one is chosen.</span><br><span> *</span><br><span> * \param uri uri to connect to</span><br><span> * \param protocols a comma separated string of supported protocols</span><br><span> * \param tls_cfg secure websocket credentials</span><br><span> * \param result result code set on client failure</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval a client websocket.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return a client websocket.</span><br><span> * \retval NULL if object could not be created or connected</span><br><span> * \since 13</span><br><span> */</span><br><span>@@ -441,7 +444,7 @@</span><br><span> * \brief Retrieve the server accepted sub-protocol on the client.</span><br><span> *</span><br><span> * \param ws the websocket client</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval the accepted client sub-protocol.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return the accepted client sub-protocol.</span><br><span> * \since 13</span><br><span> */</span><br><span> AST_OPTIONAL_API(const char *, ast_websocket_client_accept_protocol,</span><br><span>diff --git a/include/asterisk/phoneprov.h b/include/asterisk/phoneprov.h</span><br><span>index 24e8cc9..2fad829 100644</span><br><span>--- a/include/asterisk/phoneprov.h</span><br><span>+++ b/include/asterisk/phoneprov.h</span><br><span>@@ -95,7 +95,7 @@</span><br><span> /*!</span><br><span> * \brief Adds an extension</span><br><span> * \param provider_name The name of the provider</span><br><span style="color: hsl(0, 100%, 40%);">- * \param defaults An ast_vat_t linked list of the extension's variables.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param vars An ast_vat_t linked list of the extension's variables.</span><br><span> * The list is automatically cloned and it must contain at least MACADDRESS</span><br><span> * and USERNAME entries.</span><br><span> *</span><br><span>diff --git a/include/asterisk/res_hep.h b/include/asterisk/res_hep.h</span><br><span>index dba86e8..837baca 100644</span><br><span>--- a/include/asterisk/res_hep.h</span><br><span>+++ b/include/asterisk/res_hep.h</span><br><span>@@ -87,9 +87,9 @@</span><br><span> * reclaimed.</span><br><span> *</span><br><span> * \param payload The payload to send to the HEP capture node</span><br><span style="color: hsl(0, 100%, 40%);">- * \param len Length of \ref payload</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param len Length of \p payload</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval A \ref hepv3_capture_info ref counted object on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return A \ref hepv3_capture_info ref counted object on success</span><br><span> * \retval NULL on error</span><br><span> */</span><br><span> struct hepv3_capture_info *hepv3_create_capture_info(const void *payload, size_t len);</span><br><span>@@ -102,7 +102,7 @@</span><br><span> * \ref hepv3_create_capture_info.</span><br><span> *</span><br><span> * Once this function is called, it assumes ownership of the</span><br><span style="color: hsl(0, 100%, 40%);">- * \ref capture_info object and steals the reference of the</span><br><span style="color: hsl(120, 100%, 40%);">+ * \p capture_info object and steals the reference of the</span><br><span> * object. Regardless of success or failure, the calling function</span><br><span> * should assumed that this function will own the object.</span><br><span> *</span><br><span>@@ -116,7 +116,7 @@</span><br><span> *</span><br><span> * \since 13.10.0</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval The type of UUID the packet should use</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return The type of UUID the packet should use</span><br><span> */</span><br><span> enum hep_uuid_type hepv3_get_uuid_type(void);</span><br><span> </span><br><span>diff --git a/include/asterisk/res_mwi_external.h b/include/asterisk/res_mwi_external.h</span><br><span>index 19385d5..28f38d7 100644</span><br><span>--- a/include/asterisk/res_mwi_external.h</span><br><span>+++ b/include/asterisk/res_mwi_external.h</span><br><span>@@ -47,7 +47,7 @@</span><br><span> *</span><br><span> * \param mailbox_id Name of mailbox.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval object on success. The object is an ao2 object.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return object on success. The object is an ao2 object.</span><br><span> * \retval NULL on error.</span><br><span> */</span><br><span> struct ast_mwi_mailbox_object *ast_mwi_mailbox_alloc(const char *mailbox_id);</span><br><span>@@ -90,7 +90,7 @@</span><br><span> *</span><br><span> * \param mailbox What to copy.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval copy on success. The object is an ao2 object.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return copy on success. The object is an ao2 object.</span><br><span> * \retval NULL on error.</span><br><span> */</span><br><span> struct ast_mwi_mailbox_object *ast_mwi_mailbox_copy(const struct ast_mwi_mailbox_object *mailbox);</span><br><span>@@ -101,8 +101,6 @@</span><br><span> *</span><br><span> * \param mailbox Object to set number of new messages.</span><br><span> * \param num_msgs Number of messages to set.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> void ast_mwi_mailbox_set_msgs_new(struct ast_mwi_mailbox_object *mailbox, unsigned int num_msgs);</span><br><span> </span><br><span>@@ -112,8 +110,6 @@</span><br><span> *</span><br><span> * \param mailbox Object to set number of old messages.</span><br><span> * \param num_msgs Number of messages to set.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> void ast_mwi_mailbox_set_msgs_old(struct ast_mwi_mailbox_object *mailbox, unsigned int num_msgs);</span><br><span> </span><br><span>@@ -167,7 +163,7 @@</span><br><span> *</span><br><span> * \param mailbox_id Name of mailbox to retrieve.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval requested mailbox on success. The object is an ao2 object.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return requested mailbox on success. The object is an ao2 object.</span><br><span> * \retval NULL on error or no mailbox.</span><br><span> *</span><br><span> * \note The object must be treated as read-only.</span><br><span>@@ -182,7 +178,7 @@</span><br><span> *</span><br><span> * \note The provided regex is treated as extended case sensitive.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval container of struct ast_mwi_mailbox_object on success.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return container of struct ast_mwi_mailbox_object on success.</span><br><span> * \retval NULL on error.</span><br><span> *</span><br><span> * \note The objects in the container must be treated as read-only.</span><br><span>@@ -193,7 +189,7 @@</span><br><span> * \brief Get all external MWI objects.</span><br><span> * \since 12.1.0</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval container of struct ast_mwi_mailbox_object on success.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return container of struct ast_mwi_mailbox_object on success.</span><br><span> * \retval NULL on error.</span><br><span> *</span><br><span> * \note The objects in the container must be treated as read-only.</span><br><span>diff --git a/include/asterisk/res_pjproject.h b/include/asterisk/res_pjproject.h</span><br><span>index d195c0f..eee8c4e 100644</span><br><span>--- a/include/asterisk/res_pjproject.h</span><br><span>+++ b/include/asterisk/res_pjproject.h</span><br><span>@@ -59,8 +59,6 @@</span><br><span> * \note ast_pjproject_log_intercept_begin() and</span><br><span> * ast_pjproject_log_intercept_end() must always be called</span><br><span> * in pairs.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> void ast_pjproject_log_intercept_begin(int fd);</span><br><span> </span><br><span>@@ -71,8 +69,6 @@</span><br><span> * \note ast_pjproject_log_intercept_begin() and</span><br><span> * ast_pjproject_log_intercept_end() must always be called</span><br><span> * in pairs.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> void ast_pjproject_log_intercept_end(void);</span><br><span> </span><br><span>@@ -83,8 +79,6 @@</span><br><span> * \param cp Caching pool factory to initialize</span><br><span> * \param policy Pool factory policy</span><br><span> * \param max_capacity Total capacity to be retained in the cache. Zero disables caching.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> void ast_pjproject_caching_pool_init(pj_caching_pool *cp,</span><br><span> const pj_pool_factory_policy *policy, pj_size_t max_capacity);</span><br><span>@@ -94,8 +88,6 @@</span><br><span> * \since 13.21.0</span><br><span> *</span><br><span> * \param cp Caching pool factory to destroy</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> void ast_pjproject_caching_pool_destroy(pj_caching_pool *cp);</span><br><span> </span><br><span>diff --git a/include/asterisk/res_pjsip.h b/include/asterisk/res_pjsip.h</span><br><span>index 7e8637c..3fa8dcf 100644</span><br><span>--- a/include/asterisk/res_pjsip.h</span><br><span>+++ b/include/asterisk/res_pjsip.h</span><br><span>@@ -2405,9 +2405,9 @@</span><br><span> *</span><br><span> * \note Caller is responsible for freeing the allocated memory.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \param dest [out] The destination buffer</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[out] dest The destination buffer</span><br><span> * \param src The pj_str_t to copy</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval Number of characters copied or negative value on error</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return Number of characters copied or negative value on error</span><br><span> */</span><br><span> int ast_copy_pj_str2(char **dest, const pj_str_t *src);</span><br><span> </span><br><span>@@ -3388,8 +3388,6 @@</span><br><span> *</span><br><span> * \note The data object passed into the original register will have its reference count</span><br><span> * automatically decremented.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> void ast_sip_transport_monitor_unregister(pjsip_transport *transport,</span><br><span> ast_transport_monitor_shutdown_cb cb, void *data, ast_transport_monitor_data_matcher matches);</span><br><span>diff --git a/include/asterisk/res_pjsip_cli.h b/include/asterisk/res_pjsip_cli.h</span><br><span>index 36b59b2..24f92fe 100644</span><br><span>--- a/include/asterisk/res_pjsip_cli.h</span><br><span>+++ b/include/asterisk/res_pjsip_cli.h</span><br><span>@@ -28,7 +28,7 @@</span><br><span> #define CLI_MAX_TITLE_NAME 8</span><br><span> #define CLI_INDENT_TO_SPACES(x) ((x * 2) + 1 + CLI_MAX_TITLE_NAME)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief CLI Formatter Context passed to all formatters.</span><br><span> */</span><br><span> struct ast_sip_cli_context {</span><br><span>@@ -46,7 +46,7 @@</span><br><span> unsigned show_details_only_level_0 : 1;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief CLI Formatter Registry Entry</span><br><span> */</span><br><span> struct ast_sip_cli_formatter_entry {</span><br><span>diff --git a/include/asterisk/statsd.h b/include/asterisk/statsd.h</span><br><span>index 1f8468e..c3942c6 100644</span><br><span>--- a/include/asterisk/statsd.h</span><br><span>+++ b/include/asterisk/statsd.h</span><br><span>@@ -56,7 +56,7 @@</span><br><span> * updating a current value rather than resetting it.</span><br><span> *</span><br><span> * \param metric_name String (UTF-8) name of the metric.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param type_str Type of metric to send.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param metric_type Type of metric to send.</span><br><span> * \param value Value to send.</span><br><span> * \param sample_rate Percentage of samples to send.</span><br><span> * \since 13</span><br><span>@@ -94,7 +94,7 @@</span><br><span> * ast_statsd_log_sample() for a slightly more convenient interface.</span><br><span> *</span><br><span> * \param metric_name String (UTF-8) name of the metric.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param type_str Type of metric to send.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param metric_type Type of metric to send.</span><br><span> * \param value Value to send.</span><br><span> * \param sample_rate Percentage of samples to send.</span><br><span> * \since 12</span><br><span>diff --git a/res/ael/ael_lex.c b/res/ael/ael_lex.c</span><br><span>index a716a17..04821fe 100644</span><br><span>--- a/res/ael/ael_lex.c</span><br><span>+++ b/res/ael/ael_lex.c</span><br><span>@@ -2990,7 +2990,7 @@</span><br><span> }</span><br><span> </span><br><span> /** Set the current column.</span><br><span style="color: hsl(0, 100%, 40%);">- * @param line_number</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param column_no</span><br><span> * @param yyscanner The scanner object.</span><br><span> */</span><br><span> void ael_yyset_column (int column_no , yyscan_t yyscanner)</span><br><span>diff --git a/res/res_chan_stats.c b/res/res_chan_stats.c</span><br><span>index dbc79f0..6b79f12 100644</span><br><span>--- a/res/res_chan_stats.c</span><br><span>+++ b/res/res_chan_stats.c</span><br><span>@@ -49,9 +49,6 @@</span><br><span> * \brief Subscription callback for all channel messages.</span><br><span> * \param data Data pointer given when creating the subscription.</span><br><span> * \param sub This subscription.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param topic The topic the message was posted to. This is not necessarily the</span><br><span style="color: hsl(0, 100%, 40%);">- * topic you subscribed to, since messages may be forwarded between</span><br><span style="color: hsl(0, 100%, 40%);">- * topics.</span><br><span> * \param message The message itself.</span><br><span> */</span><br><span> static void statsmaker(void *data, struct stasis_subscription *sub,</span><br><span>@@ -81,9 +78,6 @@</span><br><span> * \brief Router callback for \ref stasis_cache_update messages.</span><br><span> * \param data Data pointer given when added to router.</span><br><span> * \param sub This subscription.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param topic The topic the message was posted to. This is not necessarily the</span><br><span style="color: hsl(0, 100%, 40%);">- * topic you subscribed to, since messages may be forwarded between</span><br><span style="color: hsl(0, 100%, 40%);">- * topics.</span><br><span> * \param message The message itself.</span><br><span> */</span><br><span> static void updates(void *data, struct stasis_subscription *sub,</span><br><span>@@ -131,9 +125,6 @@</span><br><span> * \brief Router callback for any message that doesn't otherwise have a route.</span><br><span> * \param data Data pointer given when added to router.</span><br><span> * \param sub This subscription.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param topic The topic the message was posted to. This is not necessarily the</span><br><span style="color: hsl(0, 100%, 40%);">- * topic you subscribed to, since messages may be forwarded between</span><br><span style="color: hsl(0, 100%, 40%);">- * topics.</span><br><span> * \param message The message itself.</span><br><span> */</span><br><span> static void default_route(void *data, struct stasis_subscription *sub,</span><br><span>diff --git a/res/res_config_ldap.c b/res/res_config_ldap.c</span><br><span>index 3d02c21..a49663a 100644</span><br><span>--- a/res/res_config_ldap.c</span><br><span>+++ b/res/res_config_ldap.c</span><br><span>@@ -98,7 +98,7 @@</span><br><span> struct ast_variable *attributes; /*!< attribute names conversion */</span><br><span> struct ast_variable *delimiters; /*!< the current delimiter is semicolon, so we are not using this variable */</span><br><span> AST_LIST_ENTRY(ldap_table_config) entry;</span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: Make proxies work */</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! \todo: Make proxies work */</span><br><span> };</span><br><span> </span><br><span> /*! \brief Should be locked before using it</span><br><span>@@ -160,7 +160,8 @@</span><br><span> return var;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! \brief Count semicolons in string</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span style="color: hsl(120, 100%, 40%);">+ * \brief Count semicolons in string</span><br><span> * \param somestr - pointer to a string</span><br><span> *</span><br><span> * \return number of occurances of the delimiter(semicolon)</span><br><span>@@ -177,7 +178,8 @@</span><br><span> return count;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* \brief Count semicolons in variables</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span style="color: hsl(120, 100%, 40%);">+ * \brief Count semicolons in variables</span><br><span> *</span><br><span> * takes a linked list of \a ast_variable variables, finds the one with the name variable_value</span><br><span> * and returns the number of semicolons in the value for that \a ast_variable</span><br><span>@@ -405,7 +407,7 @@</span><br><span> int delim_tot_count = 0;</span><br><span> int delim_count = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* \brief First find the total count</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! \brief First find the total count</span><br><span> */</span><br><span> ldap_entry = ldap_first_entry(ldapConn, ldap_result_msg);</span><br><span> </span><br><span>@@ -432,7 +434,7 @@</span><br><span> </span><br><span> i = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* \brief For each static realtime variable we may create several entries in the \a vars array if it's delimited</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! \brief For each static realtime variable we may create several entries in the \a vars array if it's delimited</span><br><span> */</span><br><span> for (entry_index = 0; ldap_entry; ) {</span><br><span> int pos = 0;</span><br><span>@@ -891,7 +893,7 @@</span><br><span> </span><br><span> ldap_msgfree(ldap_result_msg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /*! \TODO get the default variables from the accountBaseDN, not implemented with delimited values</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! \todo get the default variables from the accountBaseDN, not implemented with delimited values</span><br><span> */</span><br><span> if (vars) {</span><br><span> struct ast_variable **p = vars;</span><br><span>diff --git a/res/res_config_sqlite3.c b/res/res_config_sqlite3.c</span><br><span>index 4d99c79..5dc4784 100644</span><br><span>--- a/res/res_config_sqlite3.c</span><br><span>+++ b/res/res_config_sqlite3.c</span><br><span>@@ -565,7 +565,7 @@</span><br><span> * of rows returned from a SELECT statement and still process each row</span><br><span> * independently.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \param data user data pointer passed in via sqlite3_exec()</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param arg user data pointer passed in via sqlite3_exec()</span><br><span> * \param num_columns number of columns in the result</span><br><span> * \param values array of pointers to column values</span><br><span> * \param columns array of pointers of to column names</span><br><span>diff --git a/res/res_crypto.c b/res/res_crypto.c</span><br><span>index 7d70665..65ebcc5 100644</span><br><span>--- a/res/res_crypto.c</span><br><span>+++ b/res/res_crypto.c</span><br><span>@@ -161,7 +161,7 @@</span><br><span> * \param ifd incoming file descriptor</span><br><span> * \param ofd outgoing file descriptor</span><br><span> * \param not2</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval key on success.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return key on success.</span><br><span> * \retval NULL on failure.</span><br><span> */</span><br><span> static struct ast_key *try_load_key(const char *dir, const char *fname, int ifd, int ofd, int *not2)</span><br><span>@@ -487,7 +487,6 @@</span><br><span> * \brief refresh RSA keys from file</span><br><span> * \param ifd file descriptor</span><br><span> * \param ofd file descriptor</span><br><span style="color: hsl(0, 100%, 40%);">- * \return void</span><br><span> */</span><br><span> static void crypto_load(int ifd, int ofd)</span><br><span> {</span><br><span>@@ -546,7 +545,7 @@</span><br><span> * \param e CLI command</span><br><span> * \param cmd</span><br><span> * \param a list of CLI arguments</span><br><span style="color: hsl(0, 100%, 40%);">- * \return CLI_SUCCESS</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval CLI_SUCCESS</span><br><span> */</span><br><span> static char *handle_cli_keys_show(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)</span><br><span> {</span><br><span>@@ -592,7 +591,7 @@</span><br><span> * \param e CLI command</span><br><span> * \param cmd</span><br><span> * \param a list of CLI arguments</span><br><span style="color: hsl(0, 100%, 40%);">- * \return CLI_SUCCESS</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval CLI_SUCCESS</span><br><span> */</span><br><span> static char *handle_cli_keys_init(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)</span><br><span> {</span><br><span>diff --git a/res/res_hep.c b/res/res_hep.c</span><br><span>index 376fc4e..3241801 100644</span><br><span>--- a/res/res_hep.c</span><br><span>+++ b/res/res_hep.c</span><br><span>@@ -144,7 +144,7 @@</span><br><span> /*! A KEEP ALIVE TIMER */</span><br><span> CHUNK_TYPE_KEEP_ALIVE_TIMER = 0X000D,</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /*! THE \REF CAPTURE_PASSWORD IF DEFINED */</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! THE CAPTURE_PASSWORD IF DEFINED */</span><br><span> CHUNK_TYPE_AUTH_KEY = 0X000E,</span><br><span> </span><br><span> /*! THE ONE AND ONLY PAYLOAD */</span><br><span>diff --git a/res/res_http_websocket.c b/res/res_http_websocket.c</span><br><span>index f543b9f..624f20c 100644</span><br><span>--- a/res/res_http_websocket.c</span><br><span>+++ b/res/res_http_websocket.c</span><br><span>@@ -1085,7 +1085,8 @@</span><br><span> </span><br><span> /*! \brief Parse the given uri into a path and remote address.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * Expected uri form: [ws[s]]://<host>[:port][/<path>]</span><br><span style="color: hsl(120, 100%, 40%);">+ * Expected uri form:</span><br><span style="color: hsl(120, 100%, 40%);">+ * \verbatim [ws[s]]://<host>[:port][/<path>] \endverbatim</span><br><span> *</span><br><span> * The returned host will contain the address and optional port while</span><br><span> * path will contain everything after the address/port if included.</span><br><span>diff --git a/res/res_monitor.c b/res/res_monitor.c</span><br><span>index 235dc2d..aba4bbe 100644</span><br><span>--- a/res/res_monitor.c</span><br><span>+++ b/res/res_monitor.c</span><br><span>@@ -299,6 +299,7 @@</span><br><span> * \param fname_base filename base to record to</span><br><span> * \param need_lock whether to lock the channel mutex</span><br><span> * \param stream_action whether to record the input and/or output streams. X_REC_IN | X_REC_OUT is most often used</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param beep_id</span><br><span> * Creates the file to record, if no format is specified it assumes WAV</span><br><span> * It also sets channel variable __MONITORED=yes</span><br><span> * \retval 0 on success</span><br><span>@@ -458,7 +459,7 @@</span><br><span> * \param chan</span><br><span> * \param need_lock</span><br><span> * Stop the recording, close any open streams, mix in/out channels if required</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Always 0</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval 0 Always</span><br><span> */</span><br><span> int AST_OPTIONAL_API_NAME(ast_monitor_stop)(struct ast_channel *chan, int need_lock)</span><br><span> {</span><br><span>diff --git a/res/res_mwi_external.c b/res/res_mwi_external.c</span><br><span>index 9d56558..fac57ec 100644</span><br><span>--- a/res/res_mwi_external.c</span><br><span>+++ b/res/res_mwi_external.c</span><br><span>@@ -86,8 +86,6 @@</span><br><span> * \internal</span><br><span> * \brief Post an update event to the MWI counts.</span><br><span> * \since 12.1.0</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void mwi_post_event(const struct ast_mwi_mailbox_object *mailbox)</span><br><span> {</span><br><span>@@ -104,8 +102,6 @@</span><br><span> * \internal</span><br><span> * \brief Post a count clearing event to the MWI counts.</span><br><span> * \since 12.1.0</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void mwi_observe_delete(const void *obj)</span><br><span> {</span><br><span>@@ -254,8 +250,6 @@</span><br><span> * \since 12.1.0</span><br><span> *</span><br><span> * \param mailbox Mailbox object to delete from sorcery.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void mwi_mailbox_delete(struct ast_mwi_mailbox_object *mailbox)</span><br><span> {</span><br><span>@@ -268,8 +262,6 @@</span><br><span> * \since 12.1.0</span><br><span> *</span><br><span> * \param mailboxes Mailbox objects to delete from sorcery.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void mwi_mailbox_delete_all(struct ao2_container *mailboxes)</span><br><span> {</span><br><span>@@ -658,8 +650,6 @@</span><br><span> *</span><br><span> * \param cli_fd File descriptor for CLI output.</span><br><span> * \param mailbox What to list.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void mwi_cli_print_mailbox(int cli_fd, const struct ast_mwi_mailbox_object *mailbox)</span><br><span> {</span><br><span>@@ -676,8 +666,6 @@</span><br><span> *</span><br><span> * \param cli_fd File descriptor for CLI output.</span><br><span> * \param mailboxes What to list.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void mwi_cli_list_mailboxes(int cli_fd, struct ao2_container *mailboxes)</span><br><span> {</span><br><span>@@ -882,8 +870,6 @@</span><br><span> * \internal</span><br><span> * \brief Post initial MWI count events.</span><br><span> * \since 12.1.0</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void mwi_initial_events(void)</span><br><span> {</span><br><span>diff --git a/res/res_phoneprov.c b/res/res_phoneprov.c</span><br><span>index b0906c9..a050047 100644</span><br><span>--- a/res/res_phoneprov.c</span><br><span>+++ b/res/res_phoneprov.c</span><br><span>@@ -505,6 +505,7 @@</span><br><span> </span><br><span> /*! \brief Build a route structure and add it to the list of available http routes</span><br><span> \param pp_file File to link to the route</span><br><span style="color: hsl(120, 100%, 40%);">+ \param profile</span><br><span> \param user User to link to the route (NULL means static route)</span><br><span> \param uri URI of the route</span><br><span> */</span><br><span>diff --git a/res/res_pjsip/pjsip_resolver.c b/res/res_pjsip/pjsip_resolver.c</span><br><span>index 3d03269..2babfe4 100644</span><br><span>--- a/res/res_pjsip/pjsip_resolver.c</span><br><span>+++ b/res/res_pjsip/pjsip_resolver.c</span><br><span>@@ -92,8 +92,6 @@</span><br><span> * \brief Destroy resolution data</span><br><span> *</span><br><span> * \param data The resolution data to destroy</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void sip_resolve_destroy(void *data)</span><br><span> {</span><br><span>@@ -185,7 +183,7 @@</span><br><span> *</span><br><span> * \param data The complete resolution</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval 0 Always</span><br><span> */</span><br><span> static int sip_resolve_invoke_user_callback(void *data)</span><br><span> {</span><br><span>@@ -262,8 +260,6 @@</span><br><span> * \brief Query set callback function, invoked when all queries have completed</span><br><span> *</span><br><span> * \param query_set The completed query set</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void sip_resolve_callback(const struct ast_dns_query_set *query_set)</span><br><span> {</span><br><span>@@ -630,8 +626,6 @@</span><br><span> * \param pool A memory pool to allocate things from</span><br><span> * \param transport The type of transport to check</span><br><span> * \param name A friendly name to print in the verbose message</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void sip_check_transport(pj_pool_t *pool, pjsip_transport_type_e transport, const char *name)</span><br><span> {</span><br><span>diff --git a/res/res_pjsip_history.c b/res/res_pjsip_history.c</span><br><span>index ca86f24..de1063b 100644</span><br><span>--- a/res/res_pjsip_history.c</span><br><span>+++ b/res/res_pjsip_history.c</span><br><span>@@ -236,7 +236,7 @@</span><br><span> return !evaluate_equal(op, type, op_left, op_right);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for determining if one operand is less than another</span><br><span> */</span><br><span> static int evaluate_less_than(struct operator *op, enum aco_option_type type, void *op_left, struct expression_token *op_right)</span><br><span>@@ -285,7 +285,7 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for determining if one operand is greater than another</span><br><span> */</span><br><span> static int evaluate_greater_than(struct operator *op, enum aco_option_type type, void *op_left, struct expression_token *op_right)</span><br><span>@@ -334,7 +334,7 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for determining if one operand is less than or equal to another</span><br><span> */</span><br><span> static int evaluate_less_than_or_equal(struct operator *op, enum aco_option_type type, void *op_left, struct expression_token *op_right)</span><br><span>@@ -342,7 +342,7 @@</span><br><span> return !evaluate_greater_than(op, type, op_left, op_right);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for determining if one operand is greater than or equal to another</span><br><span> */</span><br><span> static int evaluate_greater_than_or_equal(struct operator *op, enum aco_option_type type, void *op_left, struct expression_token *op_right)</span><br><span>@@ -350,7 +350,7 @@</span><br><span> return !evaluate_less_than(op, type, op_left, op_right);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for determining logical NOT</span><br><span> */</span><br><span> static int evaluate_not(struct operator *op, enum aco_option_type type, void *operand)</span><br><span>@@ -368,7 +368,7 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for determining logical AND</span><br><span> */</span><br><span> static int evaluate_and(struct operator *op, enum aco_option_type type, void *op_left, struct expression_token *op_right)</span><br><span>@@ -386,7 +386,7 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for determining logical OR</span><br><span> */</span><br><span> static int evaluate_or(struct operator *op, enum aco_option_type type, void *op_left, struct expression_token *op_right)</span><br><span>@@ -404,7 +404,7 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Operator callback for regex 'like'</span><br><span> */</span><br><span> static int evaluate_like(struct operator *op, enum aco_option_type type, void *op_left, struct expression_token *op_right)</span><br><span>diff --git a/res/res_pjsip_mwi.c b/res/res_pjsip_mwi.c</span><br><span>index 650c402..653cd5a 100644</span><br><span>--- a/res/res_pjsip_mwi.c</span><br><span>+++ b/res/res_pjsip_mwi.c</span><br><span>@@ -679,8 +679,8 @@</span><br><span> * \param container The ao2_container to search</span><br><span> * \param endpoint The endpoint to find</span><br><span> * \param mailbox The mailbox potentially subscribed</span><br><span style="color: hsl(0, 100%, 40%);">- * \param mwi_sub [out] May contain the located mwi_subscription</span><br><span style="color: hsl(0, 100%, 40%);">- * \param mwi_stasis [out] May contain the located mwi_stasis_subscription</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[out] mwi_sub May contain the located mwi_subscription</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[out] mwi_stasis May contain the located mwi_stasis_subscription</span><br><span> *</span><br><span> * \retval 1 if a subscription was located, 0 otherwise</span><br><span> */</span><br><span>diff --git a/res/res_pjsip_notify.c b/res/res_pjsip_notify.c</span><br><span>index 9066b8c..3ae9f62 100644</span><br><span>--- a/res/res_pjsip_notify.c</span><br><span>+++ b/res/res_pjsip_notify.c</span><br><span>@@ -671,8 +671,8 @@</span><br><span> * \internal</span><br><span> * \brief Send a NOTIFY request to the endpoint.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \detail Iterates over an endpoint's AORs sending a NOTIFY request</span><br><span style="color: hsl(0, 100%, 40%);">- * with the appropriate payload information to each contact.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \details Iterates over an endpoint's AORs sending a NOTIFY request</span><br><span style="color: hsl(120, 100%, 40%);">+ * with the appropriate payload information to each contact.</span><br><span> */</span><br><span> static int notify_endpoint(void *obj)</span><br><span> {</span><br><span>@@ -1072,7 +1072,7 @@</span><br><span> };</span><br><span> </span><br><span> /*!</span><br><span style="color: hsl(0, 100%, 40%);">- * \interanl</span><br><span style="color: hsl(120, 100%, 40%);">+ * \internal</span><br><span> * \brief Completes SIPNotify AMI command in Endpoint mode.</span><br><span> */</span><br><span> static void manager_notify_endpoint(struct mansession *s,</span><br><span>diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c</span><br><span>index 7406d51..3f3de31 100644</span><br><span>--- a/res/res_pjsip_session.c</span><br><span>+++ b/res/res_pjsip_session.c</span><br><span>@@ -3722,9 +3722,9 @@</span><br><span> return SIP_GET_DEST_EXTEN_NOT_FOUND;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * /internal</span><br><span style="color: hsl(0, 100%, 40%);">- * /brief Process initial answer for an incoming invite</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span style="color: hsl(120, 100%, 40%);">+ * \internal</span><br><span style="color: hsl(120, 100%, 40%);">+ * \brief Process initial answer for an incoming invite</span><br><span> *</span><br><span> * This function should only be called during the setup, and handling of a</span><br><span> * new incoming invite. Most, if not all of the time, this will be called</span><br><span>@@ -3772,10 +3772,10 @@</span><br><span> return res;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * /internal</span><br><span style="color: hsl(0, 100%, 40%);">- * /brief Create and initialize a pjsip invite session</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span style="color: hsl(120, 100%, 40%);">+ * \internal</span><br><span style="color: hsl(120, 100%, 40%);">+ * \brief Create and initialize a pjsip invite session</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span> * pjsip_inv_session adds, and maintains a reference to the dialog upon a successful</span><br><span> * invite session creation until the session is destroyed. However, we'll wait to</span><br><span> * remove the reference that was added for the dialog when it gets created since we're</span><br><span>@@ -3785,10 +3785,10 @@</span><br><span> * created, and associated dialog locked and with two references (i.e. dialog's</span><br><span> * reference count should be 2).</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \param endpoint A pointer to the endpoint</span><br><span> * \param rdata The request that is starting the dialog</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param endpoint A pointer to the endpoint</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval A pjsip invite session object</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return A pjsip invite session object</span><br><span> * \retval NULL on error</span><br><span> */</span><br><span> static pjsip_inv_session *pre_session_setup(pjsip_rx_data *rdata, const struct ast_sip_endpoint *endpoint)</span><br><span>diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c</span><br><span>index 0f64a07..716f3a3 100644</span><br><span>--- a/res/res_rtp_asterisk.c</span><br><span>+++ b/res/res_rtp_asterisk.c</span><br><span>@@ -3462,8 +3462,6 @@</span><br><span> * \brief Start the strictrtp learning mode.</span><br><span> *</span><br><span> * \param rtp RTP session description</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void rtp_learning_start(struct ast_rtp *rtp)</span><br><span> {</span><br><span>@@ -3480,8 +3478,6 @@</span><br><span> /*!</span><br><span> * \internal</span><br><span> * \brief Resets and ACL to empty state.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void rtp_unload_acl(ast_rwlock_t *lock, struct ast_acl_list **acl)</span><br><span> {</span><br><span>diff --git a/res/res_stasis.c b/res/res_stasis.c</span><br><span>index b74e135..ea1b7a0 100644</span><br><span>--- a/res/res_stasis.c</span><br><span>+++ b/res/res_stasis.c</span><br><span>@@ -1320,7 +1320,7 @@</span><br><span> ast_channel_unlock(chan);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! /brief Stasis dialplan application callback */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief Stasis dialplan application callback */</span><br><span> int stasis_app_exec(struct ast_channel *chan, const char *app_name, int argc,</span><br><span> char *argv[])</span><br><span> {</span><br><span>@@ -2223,7 +2223,7 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* \brief Sanitization callback for channel snapshots */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief Sanitization callback for channel snapshots */</span><br><span> static int channel_snapshot_sanitizer(const struct ast_channel_snapshot *snapshot)</span><br><span> {</span><br><span> if (!snapshot || !(snapshot->tech_properties & AST_CHAN_TP_INTERNAL)) {</span><br><span>@@ -2232,7 +2232,7 @@</span><br><span> return 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* \brief Sanitization callback for channels */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief Sanitization callback for channels */</span><br><span> static int channel_sanitizer(const struct ast_channel *chan)</span><br><span> {</span><br><span> if (!chan || !(ast_channel_tech(chan)->properties & AST_CHAN_TP_INTERNAL)) {</span><br><span>@@ -2241,7 +2241,7 @@</span><br><span> return 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* \brief Sanitization callback for channel unique IDs */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief Sanitization callback for channel unique IDs */</span><br><span> static int channel_id_sanitizer(const char *id)</span><br><span> {</span><br><span> struct ast_channel_snapshot *snapshot;</span><br><span>@@ -2254,7 +2254,7 @@</span><br><span> return ret;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* \brief Sanitization callbacks for communication to Stasis applications */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief Sanitization callbacks for communication to Stasis applications */</span><br><span> struct stasis_message_sanitizer app_sanitizer = {</span><br><span> .channel_id = channel_id_sanitizer,</span><br><span> .channel_snapshot = channel_snapshot_sanitizer,</span><br><span>diff --git a/res/res_stir_shaken/certificate.h b/res/res_stir_shaken/certificate.h</span><br><span>index c95cba5..9f59afd 100644</span><br><span>--- a/res/res_stir_shaken/certificate.h</span><br><span>+++ b/res/res_stir_shaken/certificate.h</span><br><span>@@ -27,10 +27,10 @@</span><br><span> /*!</span><br><span> * \brief Get a STIR/SHAKEN certificate by caller ID number</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \param callier_id_number The caller ID number</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param caller_id_number The caller ID number</span><br><span> *</span><br><span> * \retval NULL if not found</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval The certificate on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return The certificate on success</span><br><span> */</span><br><span> struct stir_shaken_certificate *stir_shaken_certificate_get_by_caller_id_number(const char *caller_id_number);</span><br><span> </span><br><span>@@ -40,7 +40,7 @@</span><br><span> * \param cert The certificate to get the public key URL from</span><br><span> *</span><br><span> * \retval NULL on failure</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval The public key URL on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return The public key URL on success</span><br><span> */</span><br><span> const char *stir_shaken_certificate_get_public_cert_url(struct stir_shaken_certificate *cert);</span><br><span> </span><br><span>@@ -60,7 +60,7 @@</span><br><span> * \param cert The certificate to get the private key from</span><br><span> *</span><br><span> * \retval NULL on failure</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval The private key on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return The private key on success</span><br><span> */</span><br><span> EVP_PKEY *stir_shaken_certificate_get_private_key(struct stir_shaken_certificate *cert);</span><br><span> </span><br><span>@@ -94,14 +94,16 @@</span><br><span> /*!</span><br><span> * \brief Load time initialization for the stir/shaken 'certificate' configuration</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval 0 on success, -1 on error</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval 0 on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval -1 on error</span><br><span> */</span><br><span> int stir_shaken_certificate_load(void);</span><br><span> </span><br><span> /*!</span><br><span> * \brief Unload time cleanup for the stir/shaken 'certificate' configuration</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval 0 on success, -1 on error</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval 0 on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval -1 on error</span><br><span> */</span><br><span> int stir_shaken_certificate_unload(void);</span><br><span> </span><br><span>diff --git a/res/res_stir_shaken/curl.c b/res/res_stir_shaken/curl.c</span><br><span>index e765b5d..ad3adbc 100644</span><br><span>--- a/res/res_stir_shaken/curl.c</span><br><span>+++ b/res/res_stir_shaken/curl.c</span><br><span>@@ -81,6 +81,7 @@</span><br><span> /*!</span><br><span> * \brief Called when a CURL request completes</span><br><span> *</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param buffer, size, nitems</span><br><span> * \param data The curl_cb_data structure to store expiration info</span><br><span> */</span><br><span> static size_t curl_header_callback(char *buffer, size_t size, size_t nitems, void *data)</span><br><span>@@ -123,7 +124,7 @@</span><br><span> * \param data The CURL callback data</span><br><span> *</span><br><span> * \retval NULL on failure</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval CURL instance on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return CURL instance on success</span><br><span> */</span><br><span> static CURL *get_curl_instance(struct curl_cb_data *data)</span><br><span> {</span><br><span>@@ -159,7 +160,7 @@</span><br><span> * \param filename Function allocates memory and stores full filename (including path) here</span><br><span> *</span><br><span> * \retval -1 on failure</span><br><span style="color: hsl(0, 100%, 40%);">- * \retval file descriptor on success</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return file descriptor on success</span><br><span> */</span><br><span> static int create_temp_file(const char *path, char **filename)</span><br><span> {</span><br><span>diff --git a/res/res_stun_monitor.c b/res/res_stun_monitor.c</span><br><span>index 08d1d66..02cc85f 100644</span><br><span>--- a/res/res_stun_monitor.c</span><br><span>+++ b/res/res_stun_monitor.c</span><br><span>@@ -80,7 +80,7 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* \brief called by scheduler to send STUN request */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief called by scheduler to send STUN request */</span><br><span> static int stun_monitor_request(const void *blarg)</span><br><span> {</span><br><span> int res;</span><br><span>@@ -202,8 +202,6 @@</span><br><span> * \brief Stops the STUN monitor thread.</span><br><span> *</span><br><span> * \note do not hold the args->lock while calling this</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static void stun_stop_monitor(void)</span><br><span> {</span><br><span>@@ -226,8 +224,6 @@</span><br><span> * \brief Starts the STUN monitor thread.</span><br><span> *</span><br><span> * \note The args->lock MUST be held when calling this function</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \return Nothing</span><br><span> */</span><br><span> static int stun_start_monitor(void)</span><br><span> {</span><br><span>@@ -265,6 +261,7 @@</span><br><span> * \brief Parse and setup the stunaddr parameter.</span><br><span> *</span><br><span> * \param value Configuration parameter variable value.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param reload</span><br><span> *</span><br><span> * \retval 0 on success.</span><br><span> * \retval -1 on error.</span><br><span>diff --git a/res/res_xmpp.c b/res/res_xmpp.c</span><br><span>index f86828f..1c44aec 100644</span><br><span>--- a/res/res_xmpp.c</span><br><span>+++ b/res/res_xmpp.c</span><br><span>@@ -4124,7 +4124,7 @@</span><br><span> </span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Method to expose PubSub node list via CLI.</span><br><span> * \param e pointer to ast_cli_entry structure</span><br><span> * \param cmd</span><br><span>diff --git a/res/snmp/agent.h b/res/snmp/agent.h</span><br><span>index 21389d6..82f8289 100644</span><br><span>--- a/res/snmp/agent.h</span><br><span>+++ b/res/snmp/agent.h</span><br><span>@@ -17,15 +17,15 @@</span><br><span> /*!</span><br><span> * \internal</span><br><span> * \brief Thread running the SNMP Agent or Subagent</span><br><span style="color: hsl(0, 100%, 40%);">- * \param Not used -- required by pthread_create</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param arg -- not used</span><br><span> * \return A pointer with return status -- not used</span><br><span> *</span><br><span> * This represent the main thread of the SNMP [sub]agent, and</span><br><span> * will initialize SNMP and loop, processing requests until</span><br><span> * termination is requested by resetting the flag in</span><br><span style="color: hsl(0, 100%, 40%);">- * \ref res_snmp_dontStop.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \ref res_snmp_dont_stop.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-void *agent_thread(void *);</span><br><span style="color: hsl(120, 100%, 40%);">+void *agent_thread(void *arg);</span><br><span> </span><br><span> /*!</span><br><span> * \internal</span><br><span>diff --git a/res/stasis/app.h b/res/stasis/app.h</span><br><span>index a59f1dc..c6be69b 100644</span><br><span>--- a/res/stasis/app.h</span><br><span>+++ b/res/stasis/app.h</span><br><span>@@ -37,12 +37,12 @@</span><br><span> struct stasis_app;</span><br><span> </span><br><span> enum stasis_app_subscription_model {</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(120, 100%, 40%);">+ /*!</span><br><span> * \brief An application must manually subscribe to each</span><br><span> * resource that it cares about. This is the default approach.</span><br><span> */</span><br><span> STASIS_APP_SUBSCRIBE_MANUAL,</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(120, 100%, 40%);">+ /*!</span><br><span> * \brief An application is automatically subscribed to all</span><br><span> * resources in Asterisk, even if it does not control them.</span><br><span> */</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17512">change 17512</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17512"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I572e6019c422780dde5ce8448b6c85c77af6046d </div>
<div style="display:none"> Gerrit-Change-Number: 17512 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>