<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17377">View Change</a></p><div style="white-space:pre-wrap">Approvals:
George Joseph: Looks good to me, approved
Joshua Colp: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: Spelling fixes<br><br>Correct typos of the following word families:<br><br>mounting<br>jitterbuffer<br>thrashing<br>original<br>manipulating<br>entries<br>actual<br>possibility<br>tasks<br>options<br>positives<br>taskprocessor<br>other<br>dynamic<br>declarative<br><br>ASTERISK-29714<br><br>Change-Id: I6b94659d045eec5d8d020fce2e9b6e2f593dfeb6<br>---<br>M tests/CI/gates.jenkinsfile<br>M tests/CI/periodics-daily.jenkinsfile<br>M tests/CI/ref_debug.jenkinsfile<br>M tests/CI/unittests.jenkinsfile<br>M tests/test_abstract_jb.c<br>M tests/test_aoc.c<br>M tests/test_astobj2_thrash.c<br>M tests/test_config.c<br>M tests/test_hashtab_thrash.c<br>M tests/test_media_cache.c<br>M tests/test_optional_api.c<br>M tests/test_sorcery.c<br>M tests/test_sorcery_memory_cache_thrash.c<br>M tests/test_stasis.c<br>M tests/test_strings.c<br>M tests/test_taskprocessor.c<br>16 files changed, 26 insertions(+), 26 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/CI/gates.jenkinsfile b/tests/CI/gates.jenkinsfile</span><br><span>index a5465ce..48861ab 100644</span><br><span>--- a/tests/CI/gates.jenkinsfile</span><br><span>+++ b/tests/CI/gates.jenkinsfile</span><br><span>@@ -8,7 +8,7 @@</span><br><span> * pipeline, you can define the trigger in the pipeline file. This keeps</span><br><span> * everything in one place. We transition to scripted pipeline later on because</span><br><span> * we need to dynamically determine which docker image we're going to use and</span><br><span style="color: hsl(0, 100%, 40%);">- * you can't do that in a delcarative pipeline.</span><br><span style="color: hsl(120, 100%, 40%);">+ * you can't do that in a declarative pipeline.</span><br><span> */</span><br><span> def timeoutTime = 60</span><br><span> def timeoutUnits = 'MINUTES'</span><br><span>@@ -139,7 +139,7 @@</span><br><span> def r = currentBuild.startTimeInMillis % images.length</span><br><span> def ri = images[(int)r]</span><br><span> def randomImage = env.DOCKER_REGISTRY + "/" + ri</span><br><span style="color: hsl(0, 100%, 40%);">- /* FYI... Jenkins takes care of mouting the workspace for the container */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FYI... Jenkins takes care of mounting the workspace for the container */</span><br><span> def dockerOptions = "--privileged --ulimit core=0 --ulimit nofile=10240 " +</span><br><span> " --tmpfs /tmp:exec,size=1G -v /srv/jenkins:/srv/jenkins:rw -v /srv/cache:/srv/cache:rw " +</span><br><span> " --entrypoint=''"</span><br><span>diff --git a/tests/CI/periodics-daily.jenkinsfile b/tests/CI/periodics-daily.jenkinsfile</span><br><span>index 3ba8dfc..3fbffaf 100644</span><br><span>--- a/tests/CI/periodics-daily.jenkinsfile</span><br><span>+++ b/tests/CI/periodics-daily.jenkinsfile</span><br><span>@@ -8,7 +8,7 @@</span><br><span> * pipeline, you can define the trigger in the pipeline file. This keeps</span><br><span> * everything in one place. We transition to scripted pipeline later on because</span><br><span> * we need to dynamically determine which docker image we're going to use and</span><br><span style="color: hsl(0, 100%, 40%);">- * you can't do that in a delcarative pipeline.</span><br><span style="color: hsl(120, 100%, 40%);">+ * you can't do that in a declarative pipeline.</span><br><span> */</span><br><span> def timeoutTime = 3</span><br><span> def timeoutUnits = 'HOURS'</span><br><span>diff --git a/tests/CI/ref_debug.jenkinsfile b/tests/CI/ref_debug.jenkinsfile</span><br><span>index 742d5f8..c8e621b 100644</span><br><span>--- a/tests/CI/ref_debug.jenkinsfile</span><br><span>+++ b/tests/CI/ref_debug.jenkinsfile</span><br><span>@@ -8,7 +8,7 @@</span><br><span> * pipeline, you can define the trigger in the pipeline file. This keeps</span><br><span> * everything in one place. We transition to scripted pipeline later on because</span><br><span> * we need to dynamically determine which docker image we're going to use and</span><br><span style="color: hsl(0, 100%, 40%);">- * you can't do that in a delcarative pipeline.</span><br><span style="color: hsl(120, 100%, 40%);">+ * you can't do that in a declarative pipeline.</span><br><span> */</span><br><span> def timeoutTime = 24</span><br><span> def timeoutUnits = 'HOURS'</span><br><span>diff --git a/tests/CI/unittests.jenkinsfile b/tests/CI/unittests.jenkinsfile</span><br><span>index 1a0876d..24ef2f9 100644</span><br><span>--- a/tests/CI/unittests.jenkinsfile</span><br><span>+++ b/tests/CI/unittests.jenkinsfile</span><br><span>@@ -8,7 +8,7 @@</span><br><span> * pipeline, you can define the trigger in the pipeline file. This keeps</span><br><span> * everything in one place. We transition to scripted pipeline later on because</span><br><span> * we need to dynamically determine which docker image we're going to use and</span><br><span style="color: hsl(0, 100%, 40%);">- * you can't do that in a delcarative pipeline.</span><br><span style="color: hsl(120, 100%, 40%);">+ * you can't do that in a declarative pipeline.</span><br><span> */</span><br><span> def timeoutTime = 30</span><br><span> def timeoutUnits = 'MINUTES'</span><br><span>diff --git a/tests/test_abstract_jb.c b/tests/test_abstract_jb.c</span><br><span>index 76eb4bf..7826c9f 100644</span><br><span>--- a/tests/test_abstract_jb.c</span><br><span>+++ b/tests/test_abstract_jb.c</span><br><span>@@ -246,7 +246,7 @@</span><br><span> info->description = \</span><br><span> "This tests putting a single frame into a " literal_type_name " jitterbuffer " \</span><br><span> "when the jitterbuffer is empty and verifying that it is indeed " \</span><br><span style="color: hsl(0, 100%, 40%);">- "the first frame on the jitterbufffer"; \</span><br><span style="color: hsl(120, 100%, 40%);">+ "the first frame on the jitterbuffer"; \</span><br><span> return AST_TEST_NOT_RUN; \</span><br><span> case TEST_EXECUTE: \</span><br><span> break; \</span><br><span>diff --git a/tests/test_aoc.c b/tests/test_aoc.c</span><br><span>index 0adc28d..6be64c4 100644</span><br><span>--- a/tests/test_aoc.c</span><br><span>+++ b/tests/test_aoc.c</span><br><span>@@ -453,7 +453,7 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Test every billing id possiblity */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Test every billing id possibility */</span><br><span> {</span><br><span> int billid[9] = {</span><br><span> AST_AOC_BILLING_NA,</span><br><span>diff --git a/tests/test_astobj2_thrash.c b/tests/test_astobj2_thrash.c</span><br><span>index 8a7e64c..1c1c30f 100644</span><br><span>--- a/tests/test_astobj2_thrash.c</span><br><span>+++ b/tests/test_astobj2_thrash.c</span><br><span>@@ -22,7 +22,7 @@</span><br><span> * \author\verbatim David M. Lee, II <dlee@digium.com> \endverbatim</span><br><span> *</span><br><span> * Inspired by the original hashtest2.c by Steve Murphy <murf@digium.com>. This test runs</span><br><span style="color: hsl(0, 100%, 40%);">- * several threads manipulatings a concurrent astobj2 container to see if they maintain</span><br><span style="color: hsl(120, 100%, 40%);">+ * several threads manipulating a concurrent astobj2 container to see if they maintain</span><br><span> * consistency. While the tests attempt to check consistency and error normally, threading</span><br><span> * errors often result in segfaults.</span><br><span> * \ingroup tests</span><br><span>@@ -59,7 +59,7 @@</span><br><span> struct ao2_container *to_be_thrashed;</span><br><span> /*! Number of entries to insert in the grow thread. */</span><br><span> int max_grow;</span><br><span style="color: hsl(0, 100%, 40%);">- /*! Number of enteries added by the grow thread. */</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! Number of entries added by the grow thread. */</span><br><span> int grow_count;</span><br><span> /*! Entries preloaded into the hashtab; to be deleted by the shrink thread */</span><br><span> int preload;</span><br><span>diff --git a/tests/test_config.c b/tests/test_config.c</span><br><span>index c429bbe..770aa15 100644</span><br><span>--- a/tests/test_config.c</span><br><span>+++ b/tests/test_config.c</span><br><span>@@ -1493,7 +1493,7 @@</span><br><span> case TEST_INIT:</span><br><span> info->name = "config_options_test";</span><br><span> info->category = "/config/";</span><br><span style="color: hsl(0, 100%, 40%);">- info->summary = "Config opptions unit test";</span><br><span style="color: hsl(120, 100%, 40%);">+ info->summary = "Config options unit test";</span><br><span> info->description =</span><br><span> "Tests the Config Options API";</span><br><span> return AST_TEST_NOT_RUN;</span><br><span>diff --git a/tests/test_hashtab_thrash.c b/tests/test_hashtab_thrash.c</span><br><span>index ee77c92..854c00c 100644</span><br><span>--- a/tests/test_hashtab_thrash.c</span><br><span>+++ b/tests/test_hashtab_thrash.c</span><br><span>@@ -22,7 +22,7 @@</span><br><span> * \author\verbatim David M. Lee, II <dlee@digium.com> \endverbatim</span><br><span> *</span><br><span> * Inspired by the original hashtest.c by Steve Murphy <murf@digium.com>. This test runs</span><br><span style="color: hsl(0, 100%, 40%);">- * several threads manipulatings a concurrent hastab to see if they maintain</span><br><span style="color: hsl(120, 100%, 40%);">+ * several threads manipulating a concurrent hastab to see if they maintain</span><br><span> * consistency. While the tests attempt to check consistency and error normally, threading</span><br><span> * errors often result in segfaults.</span><br><span> * \ingroup tests</span><br><span>@@ -51,7 +51,7 @@</span><br><span> struct ast_hashtab *to_be_thrashed;</span><br><span> /*! Number of entries to insert in the grow thread. */</span><br><span> int max_grow;</span><br><span style="color: hsl(0, 100%, 40%);">- /*! Number of enteries added by the grow thread. */</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! Number of entries added by the grow thread. */</span><br><span> int grow_count;</span><br><span> /*! Entries preloaded into the hashtab; to be deleted by the shrink thread */</span><br><span> int preload;</span><br><span>diff --git a/tests/test_media_cache.c b/tests/test_media_cache.c</span><br><span>index c35e43f..14438f0 100644</span><br><span>--- a/tests/test_media_cache.c</span><br><span>+++ b/tests/test_media_cache.c</span><br><span>@@ -170,7 +170,7 @@</span><br><span> info->summary = "Test off nominal existance of resources in the cache";</span><br><span> info->description =</span><br><span> "This test verifies that checking for bad resources (NULL, bad "</span><br><span style="color: hsl(0, 100%, 40%);">- "scheme, etc.) does not result in false positivies.";</span><br><span style="color: hsl(120, 100%, 40%);">+ "scheme, etc.) does not result in false positives.";</span><br><span> return AST_TEST_NOT_RUN;</span><br><span> case TEST_EXECUTE:</span><br><span> break;</span><br><span>diff --git a/tests/test_optional_api.c b/tests/test_optional_api.c</span><br><span>index fdf5d0c..0bac9a5 100644</span><br><span>--- a/tests/test_optional_api.c</span><br><span>+++ b/tests/test_optional_api.c</span><br><span>@@ -20,7 +20,7 @@</span><br><span> * \file</span><br><span> * \brief Test optional API.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * This tests exercise the underlying implementation functions. Acutal usage</span><br><span style="color: hsl(120, 100%, 40%);">+ * This tests exercise the underlying implementation functions. Actual usage</span><br><span> * won't look anything like this; it would use the wrapper macros.</span><br><span> *</span><br><span> * \author\verbatim David M. Lee, II <dlee@digium.com> \endverbatim</span><br><span>diff --git a/tests/test_sorcery.c b/tests/test_sorcery.c</span><br><span>index 9f5cc7e..1f22040 100644</span><br><span>--- a/tests/test_sorcery.c</span><br><span>+++ b/tests/test_sorcery.c</span><br><span>@@ -842,7 +842,7 @@</span><br><span> ast_test_status_update(test, "A new ast_variable was not created for 'jim'\n");</span><br><span> res = AST_TEST_FAIL;</span><br><span> } else if (copy->jim == obj->jim) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_test_status_update(test, "Created copy of 'jim' is actually the ogirinal 'jim'\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_test_status_update(test, "Created copy of 'jim' is actually the original 'jim'\n");</span><br><span> res = AST_TEST_FAIL;</span><br><span> } else if (strcmp(copy->jim->value, obj->jim->value)) {</span><br><span> ast_test_status_update(test, "Value of 1st 'jim' on newly created copy is not the same as original\n");</span><br><span>diff --git a/tests/test_sorcery_memory_cache_thrash.c b/tests/test_sorcery_memory_cache_thrash.c</span><br><span>index dfe7a7c..d9ad3d1 100644</span><br><span>--- a/tests/test_sorcery_memory_cache_thrash.c</span><br><span>+++ b/tests/test_sorcery_memory_cache_thrash.c</span><br><span>@@ -61,7 +61,7 @@</span><br><span> unsigned int average_execution_time;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! \brief Structure for memory cache thrasing */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief Structure for memory cache thrashing */</span><br><span> struct sorcery_memory_cache_thrash {</span><br><span> /*! \brief The sorcery instance being tested */</span><br><span> struct ast_sorcery *sorcery;</span><br><span>@@ -160,7 +160,7 @@</span><br><span> </span><br><span> /*!</span><br><span> * \internal</span><br><span style="color: hsl(0, 100%, 40%);">- * \brief Set up thrasing against a memory cache on a sorcery instance</span><br><span style="color: hsl(120, 100%, 40%);">+ * \brief Set up thrashing against a memory cache on a sorcery instance</span><br><span> *</span><br><span> * \param cache_configuration The sorcery memory cache configuration to use</span><br><span> * \param update_threads The number of threads which should be constantly updating sorcery</span><br><span>diff --git a/tests/test_stasis.c b/tests/test_stasis.c</span><br><span>index 08c3d1e..5efb1ec 100644</span><br><span>--- a/tests/test_stasis.c</span><br><span>+++ b/tests/test_stasis.c</span><br><span>@@ -259,7 +259,7 @@</span><br><span> if (r == ETIMEDOUT) {</span><br><span> break;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- ast_assert(r == 0); /* Not expecting any othet types of errors */</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_assert(r == 0); /* Not expecting any other types of errors */</span><br><span> }</span><br><span> return consumer->messages_rxed_len;</span><br><span> }</span><br><span>@@ -280,7 +280,7 @@</span><br><span> if (r == ETIMEDOUT) {</span><br><span> break;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- ast_assert(r == 0); /* Not expecting any othet types of errors */</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_assert(r == 0); /* Not expecting any other types of errors */</span><br><span> }</span><br><span> return consumer->complete;</span><br><span> }</span><br><span>@@ -306,7 +306,7 @@</span><br><span> if (r == ETIMEDOUT) {</span><br><span> break;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- ast_assert(r == 0); /* Not expecting any othet types of errors */</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_assert(r == 0); /* Not expecting any other types of errors */</span><br><span> }</span><br><span> return consumer->messages_rxed_len;</span><br><span> }</span><br><span>diff --git a/tests/test_strings.c b/tests/test_strings.c</span><br><span>index 63ac856..f3c7e56 100644</span><br><span>--- a/tests/test_strings.c</span><br><span>+++ b/tests/test_strings.c</span><br><span>@@ -22,7 +22,7 @@</span><br><span> *</span><br><span> * \author Mark Michelson <mmichelson@digium.com></span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * This module will run some dyanmic string tests.</span><br><span style="color: hsl(120, 100%, 40%);">+ * This module will run some dynamic string tests.</span><br><span> *</span><br><span> * \ingroup tests</span><br><span> */</span><br><span>diff --git a/tests/test_taskprocessor.c b/tests/test_taskprocessor.c</span><br><span>index c9a40df..537f77c 100644</span><br><span>--- a/tests/test_taskprocessor.c</span><br><span>+++ b/tests/test_taskprocessor.c</span><br><span>@@ -139,7 +139,7 @@</span><br><span> case TEST_INIT:</span><br><span> info->name = "default_taskprocessor";</span><br><span> info->category = "/main/taskprocessor/";</span><br><span style="color: hsl(0, 100%, 40%);">- info->summary = "Test of default taskproccesor";</span><br><span style="color: hsl(120, 100%, 40%);">+ info->summary = "Test of default taskprocessor";</span><br><span> info->description =</span><br><span> "Ensures that a queued task gets executed.";</span><br><span> return AST_TEST_NOT_RUN;</span><br><span>@@ -363,7 +363,7 @@</span><br><span> case TEST_INIT:</span><br><span> info->name = "default_taskprocessor_load";</span><br><span> info->category = "/main/taskprocessor/";</span><br><span style="color: hsl(0, 100%, 40%);">- info->summary = "Load test of default taskproccesor";</span><br><span style="color: hsl(120, 100%, 40%);">+ info->summary = "Load test of default taskprocessor";</span><br><span> info->description =</span><br><span> "Ensure that a large number of queued tasks are executed in the proper order.";</span><br><span> return AST_TEST_NOT_RUN;</span><br><span>@@ -546,7 +546,7 @@</span><br><span> /*!</span><br><span> * \brief Test for a taskprocessor with custom listener.</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * This test pushes tasks to a taskprocessor with a custom listener, executes the taskss,</span><br><span style="color: hsl(120, 100%, 40%);">+ * This test pushes tasks to a taskprocessor with a custom listener, executes the tasks,</span><br><span> * and destroys the taskprocessor.</span><br><span> *</span><br><span> * The test ensures that the listener's callbacks are called when expected and that the data</span><br><span>@@ -563,7 +563,7 @@</span><br><span> case TEST_INIT:</span><br><span> info->name = "taskprocessor_listener";</span><br><span> info->category = "/main/taskprocessor/";</span><br><span style="color: hsl(0, 100%, 40%);">- info->summary = "Test of taskproccesor listeners";</span><br><span style="color: hsl(120, 100%, 40%);">+ info->summary = "Test of taskprocessor listeners";</span><br><span> info->description =</span><br><span> "Ensures that listener callbacks are called when expected.";</span><br><span> return AST_TEST_NOT_RUN;</span><br><span>@@ -760,7 +760,7 @@</span><br><span> case TEST_INIT:</span><br><span> info->name = "taskprocessor_shutdown";</span><br><span> info->category = "/main/taskprocessor/";</span><br><span style="color: hsl(0, 100%, 40%);">- info->summary = "Test of taskproccesor shutdown sequence";</span><br><span style="color: hsl(120, 100%, 40%);">+ info->summary = "Test of taskprocessor shutdown sequence";</span><br><span> info->description =</span><br><span> "Ensures that all tasks run to completion after the taskprocessor has been unref'ed.";</span><br><span> return AST_TEST_NOT_RUN;</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17377">change 17377</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17377"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I6b94659d045eec5d8d020fce2e9b6e2f593dfeb6 </div>
<div style="display:none"> Gerrit-Change-Number: 17377 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Josh Soref <jsoref@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>