<p> Attention is currently required from: Kevin Harwell. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16642">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/json.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16642/comment/bb18ea13_66d16a5a">Patch Set #1, Line 544:</a> <code style="font-family:monospace,monospace">\param excludes Variable names to exclude (optional)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comma separated?  Space separated?, etc?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/json.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16642/comment/0bc90181_ed7a6d58">Patch Set #1, Line 867:</a> <code style="font-family:monospace,monospace">strstr(excludes, i->name)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If you exclude ABC, than all variables that have ABC somewhere in the name will be excluded.   I.E. ABC, MYABC, ABCMY, YOURABCMY will all be excluded.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You could use ast_strsep with the AST_STRSEP_TRIM flag and just iterate over the excludes string.  Actually, I'm surprised we don't have a macro that does just that give how often we do this.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File tests/test_json.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16642/comment/9923702b_3f82e93c">Patch Set #1, Line 1112:</a> <code style="font-family:monospace,monospace">    /* NULL case */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You should probably also test that "ABC" doesn't match "MYABC2" in the excludes string.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16642">change 16642</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16642"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I5f34f18e102126aef3997f19a553a266d70d6226 </div>
<div style="display:none"> Gerrit-Change-Number: 16642 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Oct 2021 12:15:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>