<p>George Joseph <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16493">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">apps/app_playback.c: Add 'mix' option to app_playback<br><br>I am adding a mix option that will play by filename and say.conf unlike<br>say option that will only play with say.conf. It<br>will look on the format of the name, if it is like say it play with<br>say.conf if not it will play the file name.<br><br>ASTERISK-29662<br><br>Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a<br>---<br>M apps/app_playback.c<br>A doc/CHANGES-staging/add_mix_option_to_playback.txt<br>2 files changed, 23 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_playback.c b/apps/app_playback.c</span><br><span>index 0c9281a..ab6e60e 100644</span><br><span>--- a/apps/app_playback.c</span><br><span>+++ b/apps/app_playback.c</span><br><span>@@ -62,6 +62,12 @@</span><br><span>                                           be answered before the sound is played.</para></span><br><span>                                                 <note><para>Not all channel types support playing messages while still on hook.</para></note></span><br><span>                                        </option></span><br><span style="color: hsl(120, 100%, 40%);">+                                       <option name="say"></span><br><span style="color: hsl(120, 100%, 40%);">+                                           <para>Play using the say.conf file.</para></span><br><span style="color: hsl(120, 100%, 40%);">+                                        </option></span><br><span style="color: hsl(120, 100%, 40%);">+                                       <option name="mix"></span><br><span style="color: hsl(120, 100%, 40%);">+                                           <para>Play using a mix of filename and the say.conf file.</para></span><br><span style="color: hsl(120, 100%, 40%);">+                                  </option></span><br><span>                              </optionlist></span><br><span>                  </parameter></span><br><span>           </syntax></span><br><span>@@ -446,6 +452,7 @@</span><br><span>        char *tmp;</span><br><span>   int option_skip=0;</span><br><span>   int option_say=0;</span><br><span style="color: hsl(120, 100%, 40%);">+     int option_mix=0;</span><br><span>    int option_noanswer = 0;</span><br><span> </span><br><span>         AST_DECLARE_APP_ARGS(args,</span><br><span>@@ -466,6 +473,8 @@</span><br><span>                     option_skip = 1;</span><br><span>             if (strcasestr(args.options, "say"))</span><br><span>                       option_say = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+               if (strcasestr(args.options, "mix"))</span><br><span style="color: hsl(120, 100%, 40%);">+                        option_mix = 1;</span><br><span>              if (strcasestr(args.options, "noanswer"))</span><br><span>                  option_noanswer = 1;</span><br><span>         }</span><br><span>@@ -486,6 +495,13 @@</span><br><span>             while (!res && (front = strsep(&back, "&"))) {</span><br><span>                     if (option_say)</span><br><span>                              res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+                  else if (option_mix){</span><br><span style="color: hsl(120, 100%, 40%);">+                         /* Check if it is in say format but not remote audio file */</span><br><span style="color: hsl(120, 100%, 40%);">+                          if (strcasestr(front, ":") && !strcasestr(front, "://"))</span><br><span style="color: hsl(120, 100%, 40%);">+                                  res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+                          else</span><br><span style="color: hsl(120, 100%, 40%);">+                                  res = ast_streamfile(chan, front, ast_channel_language(chan));</span><br><span style="color: hsl(120, 100%, 40%);">+                        }</span><br><span>                    else</span><br><span>                                 res = ast_streamfile(chan, front, ast_channel_language(chan));</span><br><span>                       if (!res) {</span><br><span>diff --git a/doc/CHANGES-staging/add_mix_option_to_playback.txt b/doc/CHANGES-staging/add_mix_option_to_playback.txt</span><br><span>new file mode 100644</span><br><span>index 0000000..cfc876c</span><br><span>--- /dev/null</span><br><span>+++ b/doc/CHANGES-staging/add_mix_option_to_playback.txt</span><br><span>@@ -0,0 +1,7 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: app_playback</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: apps</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+A new option 'mix' is added to the Playback application that </span><br><span style="color: hsl(120, 100%, 40%);">+will play by filename and say.conf. It will look on the format of the </span><br><span style="color: hsl(120, 100%, 40%);">+name, if it is like say format it will play with say.conf if not it </span><br><span style="color: hsl(120, 100%, 40%);">+will play the file name.</span><br><span>\ No newline at end of file</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16493">change 16493</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16493"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a </div>
<div style="display:none"> Gerrit-Change-Number: 16493 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: Shloime Rosenblum <shloimerosenblum@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>