<p>George Joseph has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16556">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_read: Fix null pointer crash<br><br>If the terminator character is not explicitly specified<br>and an indications tone is used for reading a digit,<br>there is no null pointer check so Asterisk crashes.<br>This prevents null usage from occuring.<br><br>ASTERISK-29673 #close<br><br>Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac<br>---<br>M apps/app_read.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/56/16556/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_read.c b/apps/app_read.c</span><br><span>index dd48f05..977b20d 100644</span><br><span>--- a/apps/app_read.c</span><br><span>+++ b/apps/app_read.c</span><br><span>@@ -154,7 +154,7 @@</span><br><span>  struct ast_tone_zone_sound *ts = NULL;</span><br><span>       struct ast_flags flags = {0};</span><br><span>        const char *status = "ERROR";</span><br><span style="color: hsl(0, 100%, 40%);">- char *terminator = NULL; /* use default terminator # by default */</span><br><span style="color: hsl(120, 100%, 40%);">+    char *terminator = "#"; /* use default terminator # by default */</span><br><span> </span><br><span>      AST_DECLARE_APP_ARGS(arglist,</span><br><span>                AST_APP_ARG(variable);</span><br><span>@@ -213,7 +213,7 @@</span><br><span>                 }</span><br><span>    }</span><br><span>    if (ast_test_flag(&flags, OPT_TERMINATOR)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                if (!ast_strlen_zero(arglist.filename)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (!ast_strlen_zero(opt_args[OPT_ARG_TERMINATOR])) {</span><br><span>                        terminator = opt_args[OPT_ARG_TERMINATOR];</span><br><span>           } else {</span><br><span>                     terminator = ""; /* no digit inherently will terminate input */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16556">change 16556</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16556"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18.7 </div>
<div style="display:none"> Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac </div>
<div style="display:none"> Gerrit-Change-Number: 16556 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>