<p> Attention is currently required from: Shloime Rosenblum. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16540">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16540?tab=comments">Patch Set #3:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">This will need a CHANGES entry</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_playback.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16540/comment/6efa9300_43948c0f">Patch Set #3, Line 55:</a> <code style="font-family:monospace,monospace">                          <para>List of options (You can do Playback(filename,skipmix) or Playback(filename,mix|skip) but you can't use a comma as a delimeter).</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If a comma separated list was allowed before, then no longer allowing such technically could break current dialplan (even if it seems unlikely).</p><p style="white-space: pre-wrap; word-wrap: break-word;">Why can the options not still be comma separated?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16540/comment/4bcf7cf9_22fc405d">Patch Set #3, Line 498:</a> <code style="font-family:monospace,monospace">                    else if (option_mix){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">add a space between closing ')' and '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16540/comment/04f3ccfc_e972ae35">Patch Set #3, Line 500:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                            if (strcasestr(front, ":") && !strcasestr(front, "://"))<br>                                  res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);<br>                          else<br>                                  res = ast_streamfile(chan, front, ast_channel_language(chan));<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You could combine this with the "else if" above and then drop the associated else if you wanted. For example:</p><p style="white-space: pre-wrap; word-wrap: break-word;">else if (option_mix && strcase(...) && ....) {</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also please use begin/end brackets for all if/else statements even if they are single line.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16540">change 16540</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16540"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a </div>
<div style="display:none"> Gerrit-Change-Number: 16540 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Shloime Rosenblum <shloimerosenblum@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Shloime Rosenblum <shloimerosenblum@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 29 Sep 2021 21:13:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>