<p> Attention is currently required from: Sean Bright. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16419">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File tests/test_abstract_jb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16419/comment/a000fec0_b14d318b">Patch Set #2, Line 321:</a> <code style="font-family:monospace,monospace"> jb->impl->put_first(jb->jbobj, expected_frame, 1100); \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This will leak expected_frame if AST_JB_IMPL_OK is not returned, so should add a check here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16419/comment/b21f5525_78361301">Patch Set #2, Line 328:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_test_status_update(test, "Error: On frame %d, got %d back from put (expected %d)\n", \<br> i, res, AST_JB_IMPL_OK); \<br> return AST_TEST_FAIL; \<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">expected_frame needs freeing here as well.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16419/comment/ae966ee4_85e8a4d5">Patch Set #2, Line 339:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_test_status_update(test, "Error: failed to retrieve frame %i at time %ld\n", \<br> i, next); \<br> return AST_TEST_FAIL; \<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">expected_frame needs freeing in this path too.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16419/comment/a60dc3ee_81113df8">Patch Set #2, Line 457:</a> <code style="font-family:monospace,monospace"> jb->impl->put_first(jb->jbobj, expected_frame, 1100); \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Similar to other one, check result and possibly free expected_frame.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16419/comment/79012011_b4d7977c">Patch Set #2, Line 470:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_test_status_update(test, "Error: On frame %d, got %d back from put (expected %d)\n", \<br> i, res, AST_JB_IMPL_OK); \<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">free expected_frame</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16419/comment/041f8c6a_6e302a8e">Patch Set #2, Line 481:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_test_status_update(test, "Error: failed to retrieve frame at %ld\n", \<br> next); \<br> return AST_TEST_FAIL; \<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Free expected_frame here too.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16419">change 16419</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16419"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ib575616101230c4f603519114ec62ebf3936882c </div>
<div style="display:none"> Gerrit-Change-Number: 16419 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 08 Sep 2021 23:16:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>