<p>George Joseph <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16168">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Kevin Harwell: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_rtp_asterisk: Automatically refresh stunaddr from DNS<br><br>This allows the STUN server to change its IP address without having to<br>reload the res_rtp_asterisk module.<br><br>The refresh of the name resolution occurs first when the module is<br>loaded, then recurringly, slightly after the previous DNS answer TTL<br>expires.<br><br>ASTERISK-29508 #close<br><br>Change-Id: I7955a046293f913ba121bbd82153b04439e3465f<br>---<br>M configs/samples/rtp.conf.sample<br>A doc/CHANGES-staging/res_rtp_asterisk_stunaddr_recurring_resolution.txt<br>M main/dns_recurring.c<br>M res/res_rtp_asterisk.c<br>4 files changed, 137 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configs/samples/rtp.conf.sample b/configs/samples/rtp.conf.sample</span><br><span>index 1207c78..3027b95 100644</span><br><span>--- a/configs/samples/rtp.conf.sample</span><br><span>+++ b/configs/samples/rtp.conf.sample</span><br><span>@@ -63,7 +63,8 @@</span><br><span> ; Hostname or address for the STUN server used when determining the external</span><br><span> ; IP address and port an RTP session can be reached at. The port number is</span><br><span> ; optional. If omitted the default value of 3478 will be used. This option is</span><br><span style="color: hsl(0, 100%, 40%);">-; disabled by default.</span><br><span style="color: hsl(120, 100%, 40%);">+; disabled by default. Name resolution will occur at load time, and if DNS is</span><br><span style="color: hsl(120, 100%, 40%);">+; used, name resolution will occur repeatedly after the TTL expires.</span><br><span> ;</span><br><span> ; e.g. stundaddr=mystun.server.com:3478</span><br><span> ;</span><br><span>diff --git a/doc/CHANGES-staging/res_rtp_asterisk_stunaddr_recurring_resolution.txt b/doc/CHANGES-staging/res_rtp_asterisk_stunaddr_recurring_resolution.txt</span><br><span>new file mode 100644</span><br><span>index 0000000..c78f4f5</span><br><span>--- /dev/null</span><br><span>+++ b/doc/CHANGES-staging/res_rtp_asterisk_stunaddr_recurring_resolution.txt</span><br><span>@@ -0,0 +1,6 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: res_rtp_asterisk</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+When the address of the STUN server (stunaddr) is a name resolved via DNS, the</span><br><span style="color: hsl(120, 100%, 40%);">+stunaddr will be recurringly resolved when the DNS answer Time-To-Live (TTL)</span><br><span style="color: hsl(120, 100%, 40%);">+expires. This allows the STUN server to change its IP address without having to</span><br><span style="color: hsl(120, 100%, 40%);">+reload the res_rtp_asterisk module.</span><br><span>diff --git a/main/dns_recurring.c b/main/dns_recurring.c</span><br><span>index 294438f..6a953fa 100644</span><br><span>--- a/main/dns_recurring.c</span><br><span>+++ b/main/dns_recurring.c</span><br><span>@@ -39,6 +39,11 @@</span><br><span> </span><br><span> #include <arpa/nameser.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* \brief Delay between TTL expiration and the next DNS query, to make sure the</span><br><span style="color: hsl(120, 100%, 40%);">+resolver cache really expired. */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EXTRA_TTL 2</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAX_TTL ((INT_MAX - EXTRA_TTL) / 1000)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! \brief Destructor for a DNS query */</span><br><span> static void dns_query_recurring_destroy(void *data)</span><br><span> {</span><br><span>@@ -91,10 +96,10 @@</span><br><span> /* So.. if something has not externally cancelled this we can reschedule based on the TTL */</span><br><span> if (!recurring->cancelled) {</span><br><span> const struct ast_dns_result *result = ast_dns_query_get_result(query);</span><br><span style="color: hsl(0, 100%, 40%);">- int ttl = MIN(ast_dns_result_get_lowest_ttl(result), INT_MAX / 1000);</span><br><span style="color: hsl(120, 100%, 40%);">+ int ttl = MIN(ast_dns_result_get_lowest_ttl(result), MAX_TTL);</span><br><span> </span><br><span> if (ttl) {</span><br><span style="color: hsl(0, 100%, 40%);">- recurring->timer = ast_sched_add(ast_dns_get_sched(), ttl * 1000, dns_query_recurring_scheduled_callback, ao2_bump(recurring));</span><br><span style="color: hsl(120, 100%, 40%);">+ recurring->timer = ast_sched_add(ast_dns_get_sched(), (ttl + EXTRA_TTL) * 1000, dns_query_recurring_scheduled_callback, ao2_bump(recurring));</span><br><span> if (recurring->timer < 0) {</span><br><span> /* It is impossible for this to be the last reference as the query has a reference to it */</span><br><span> ao2_ref(recurring, -1);</span><br><span>diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c</span><br><span>index 5227e94..6da4824 100644</span><br><span>--- a/res/res_rtp_asterisk.c</span><br><span>+++ b/res/res_rtp_asterisk.c</span><br><span>@@ -36,6 +36,11 @@</span><br><span> </span><br><span> #include "asterisk.h"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <arpa/nameser.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include "asterisk/dns_core.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "asterisk/dns_internal.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "asterisk/dns_recurring.h"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #include <sys/time.h></span><br><span> #include <signal.h></span><br><span> #include <fcntl.h></span><br><span>@@ -230,6 +235,10 @@</span><br><span> static struct ast_acl_list *stun_acl = NULL;</span><br><span> static ast_rwlock_t stun_acl_lock = AST_RWLOCK_INIT_VALUE;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! stunaddr recurring resolution */</span><br><span style="color: hsl(120, 100%, 40%);">+static ast_rwlock_t stunaddr_lock = AST_RWLOCK_INIT_VALUE;</span><br><span style="color: hsl(120, 100%, 40%);">+static struct ast_dns_query_recurring *stunaddr_resolver = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! \brief Pool factory used by pjlib to allocate memory. */</span><br><span> static pj_caching_pool cachingpool;</span><br><span> </span><br><span>@@ -646,6 +655,9 @@</span><br><span> </span><br><span> static int __rtp_sendto(struct ast_rtp_instance *instance, void *buf, size_t size, int flags, struct ast_sockaddr *sa, int rtcp, int *via_ice, int use_srtp);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void stunaddr_resolve_callback(const struct ast_dns_query *query);</span><br><span style="color: hsl(120, 100%, 40%);">+static int store_stunaddr_resolved(const struct ast_dns_query *query);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #if defined(HAVE_OPENSSL) && (OPENSSL_VERSION_NUMBER >= 0x10001000L) && !defined(OPENSSL_NO_SRTP)</span><br><span> static int dtls_bio_new(BIO *bio)</span><br><span> {</span><br><span>@@ -3529,6 +3541,7 @@</span><br><span> pj_sockaddr pjtmp;</span><br><span> struct ast_ice_host_candidate *candidate;</span><br><span> int af_inet_ok = 0, af_inet6_ok = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct sockaddr_in stunaddr_copy;</span><br><span> </span><br><span> if (ast_sockaddr_is_ipv4(addr)) {</span><br><span> af_inet_ok = 1;</span><br><span>@@ -3638,8 +3651,12 @@</span><br><span> freeifaddrs(ifa);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_rdlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(&stunaddr_copy, &stunaddr, sizeof(stunaddr));</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_unlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* If configured to use a STUN server to get our external mapped address do so */</span><br><span style="color: hsl(0, 100%, 40%);">- if (stunaddr.sin_addr.s_addr && !stun_address_is_blacklisted(addr) &&</span><br><span style="color: hsl(120, 100%, 40%);">+ if (stunaddr_copy.sin_addr.s_addr && !stun_address_is_blacklisted(addr) &&</span><br><span> (ast_sockaddr_is_ipv4(addr) || ast_sockaddr_is_any(addr)) &&</span><br><span> count < PJ_ICE_MAX_CAND) {</span><br><span> struct sockaddr_in answer;</span><br><span>@@ -3656,7 +3673,7 @@</span><br><span> */</span><br><span> ao2_unlock(instance);</span><br><span> rsp = ast_stun_request(component == AST_RTP_ICE_COMPONENT_RTCP</span><br><span style="color: hsl(0, 100%, 40%);">- ? rtp->rtcp->s : rtp->s, &stunaddr, NULL, &answer);</span><br><span style="color: hsl(120, 100%, 40%);">+ ? rtp->rtcp->s : rtp->s, &stunaddr_copy, NULL, &answer);</span><br><span> ao2_lock(instance);</span><br><span> if (!rsp) {</span><br><span> struct ast_rtp_engine_ice_candidate *candidate;</span><br><span>@@ -9009,6 +9026,72 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void stunaddr_resolve_callback(const struct ast_dns_query *query)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const int lowest_ttl = ast_dns_result_get_lowest_ttl(ast_dns_query_get_result(query));</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *stunaddr_name = ast_dns_query_get_name(query);</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *stunaddr_resolved_str;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!store_stunaddr_resolved(query)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_log(LOG_WARNING, "Failed to resolve stunaddr '%s'. Cancelling recurring resolution.\n", stunaddr_name);</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (DEBUG_ATLEAST(2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_rdlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ stunaddr_resolved_str = ast_inet_ntoa(stunaddr.sin_addr);</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_unlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_debug_stun(2, "Resolved stunaddr '%s' to '%s'. Lowest TTL = %d.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ stunaddr_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ stunaddr_resolved_str,</span><br><span style="color: hsl(120, 100%, 40%);">+ lowest_ttl);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!lowest_ttl) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_log(LOG_WARNING, "Resolution for stunaddr '%s' returned TTL = 0. Recurring resolution was cancelled.\n", ast_dns_query_get_name(query));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int store_stunaddr_resolved(const struct ast_dns_query *query)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct ast_dns_result *result = ast_dns_query_get_result(query);</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct ast_dns_record *record;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (record = ast_dns_result_get_records(result); record; record = ast_dns_record_get_next(record)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t data_size = ast_dns_record_get_data_size(record);</span><br><span style="color: hsl(120, 100%, 40%);">+ const unsigned char *data = (unsigned char *)ast_dns_record_get_data(record);</span><br><span style="color: hsl(120, 100%, 40%);">+ const int rr_type = ast_dns_record_get_rr_type(record);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rr_type == ns_t_a && data_size == 4) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_wrlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(&stunaddr.sin_addr, data, data_size);</span><br><span style="color: hsl(120, 100%, 40%);">+ stunaddr.sin_family = AF_INET;</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_unlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_debug_stun(3, "Unrecognized rr_type '%u' or data_size '%zu' from DNS query for stunaddr '%s'\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ rr_type, data_size, ast_dns_query_get_name(query));</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void clean_stunaddr(void) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (stunaddr_resolver) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_dns_resolve_recurring_cancel(stunaddr_resolver)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_log(LOG_ERROR, "Failed to cancel recurring DNS resolution of previous stunaddr.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ ao2_ref(stunaddr_resolver, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ stunaddr_resolver = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_wrlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&stunaddr, 0, sizeof(stunaddr));</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_unlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #if defined(HAVE_OPENSSL) && (OPENSSL_VERSION_NUMBER >= 0x10001000L) && !defined(OPENSSL_NO_SRTP)</span><br><span> /*! \pre instance is locked */</span><br><span> static int ast_rtp_activate(struct ast_rtp_instance *instance)</span><br><span>@@ -9106,6 +9189,7 @@</span><br><span> </span><br><span> static char *handle_cli_rtp_settings(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct sockaddr_in stunaddr_copy;</span><br><span> switch (cmd) {</span><br><span> case CLI_INIT:</span><br><span> e->command = "rtp show settings";</span><br><span>@@ -9138,6 +9222,11 @@</span><br><span> ast_cli(a->fd, " Replay Protect: %s\n", AST_CLI_YESNO(srtp_replay_protection));</span><br><span> #ifdef HAVE_PJPROJECT</span><br><span> ast_cli(a->fd, " ICE support: %s\n", AST_CLI_YESNO(icesupport));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_rdlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(&stunaddr_copy, &stunaddr, sizeof(stunaddr));</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_unlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_cli(a->fd, " STUN address: %s:%d\n", ast_inet_ntoa(stunaddr_copy.sin_addr), htons(stunaddr_copy.sin_port));</span><br><span> #endif</span><br><span> return CLI_SUCCESS;</span><br><span> }</span><br><span>@@ -9386,7 +9475,7 @@</span><br><span> icesupport = DEFAULT_ICESUPPORT;</span><br><span> stun_software_attribute = DEFAULT_STUN_SOFTWARE_ATTRIBUTE;</span><br><span> turnport = DEFAULT_TURN_PORT;</span><br><span style="color: hsl(0, 100%, 40%);">- memset(&stunaddr, 0, sizeof(stunaddr));</span><br><span style="color: hsl(120, 100%, 40%);">+ clean_stunaddr();</span><br><span> turnaddr = pj_str(NULL);</span><br><span> turnusername = pj_str(NULL);</span><br><span> turnpassword = pj_str(NULL);</span><br><span>@@ -9464,9 +9553,35 @@</span><br><span> stun_software_attribute = ast_true(s);</span><br><span> }</span><br><span> if ((s = ast_variable_retrieve(cfg, "general", "stunaddr"))) {</span><br><span style="color: hsl(0, 100%, 40%);">- stunaddr.sin_port = htons(STANDARD_STUN_PORT);</span><br><span style="color: hsl(0, 100%, 40%);">- if (ast_parse_arg(s, PARSE_INADDR, &stunaddr)) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_log(LOG_WARNING, "Invalid STUN server address: %s\n", s);</span><br><span style="color: hsl(120, 100%, 40%);">+ char *hostport, *host, *port;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int port_parsed = STANDARD_STUN_PORT;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ast_sockaddr stunaddr_parsed;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ hostport = ast_strdupa(s);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!ast_parse_arg(hostport, PARSE_ADDR, &stunaddr_parsed)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_debug_stun(3, "stunaddr = '%s' does not need name resolution\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_sockaddr_stringify_host(&stunaddr_parsed));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!ast_sockaddr_port(&stunaddr_parsed)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_sockaddr_set_port(&stunaddr_parsed, STANDARD_STUN_PORT);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_wrlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_sockaddr_to_sin(&stunaddr_parsed, &stunaddr);</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rwlock_unlock(&stunaddr_lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (ast_sockaddr_split_hostport(hostport, &host, &port, 0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (port) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_parse_arg(port, PARSE_UINT32|PARSE_IN_RANGE, &port_parsed, 1, 65535);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ stunaddr.sin_port = htons(port_parsed);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ stunaddr_resolver = ast_dns_resolve_recurring(host, T_A, C_IN,</span><br><span style="color: hsl(120, 100%, 40%);">+ &stunaddr_resolve_callback, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!stunaddr_resolver) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_log(LOG_ERROR, "Failed to setup recurring DNS resolution of stunaddr '%s'",</span><br><span style="color: hsl(120, 100%, 40%);">+ host);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_log(LOG_ERROR, "Failed to parse stunaddr '%s'", hostport);</span><br><span> }</span><br><span> }</span><br><span> if ((s = ast_variable_retrieve(cfg, "general", "turnaddr"))) {</span><br><span>@@ -9726,6 +9841,7 @@</span><br><span> acl_change_sub = stasis_unsubscribe_and_join(acl_change_sub);</span><br><span> rtp_unload_acl(&ice_acl_lock, &ice_acl);</span><br><span> rtp_unload_acl(&stun_acl_lock, &stun_acl);</span><br><span style="color: hsl(120, 100%, 40%);">+ clean_stunaddr();</span><br><span> #endif</span><br><span> </span><br><span> return 0;</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16168">change 16168</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16168"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I7955a046293f913ba121bbd82153b04439e3465f </div>
<div style="display:none"> Gerrit-Change-Number: 16168 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>