<p> Attention is currently required from: N A, Joshua Colp. </p>
<p>Patch set 8:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16222">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_verbose.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/14d3c102_f7390f62">Patch Set #8, Line 65:</a> <code style="font-family:monospace,monospace">, or </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Extra ', or'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/logger.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/36a5137e_905a05c3">Patch Set #8, Line 138:</a> <code style="font-family:monospace,monospace">;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add <custom_level></p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/51ad5803_f6a3739d">Patch Set #8, Line 184:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add:<br>; A log level defined in 'custom_levels' above<br>;important.log = important</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File doc/CHANGES-staging/logger.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/b5ab2657_32adfbac">Patch Set #8, Line 3:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Adds the ability for custom logging levels<br>to be user-specified.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Added the ability to define custom log levels in logger.conf<br>and use them in the Verbose dialplan application.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/logger.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/6bb25550_e201127b">Patch Set #8, Line 338:</a> <code style="font-family:monospace,monospace">ast_logger_dynamic_level</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd make this more descriptive: ast_logger_get_dynamic_level.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/logger.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/1bd3706f_e756b985">Patch Set #8, Line 820:</a> <code style="font-family:monospace,monospace"> logger_register_level(logfile);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">init_logger_chain() also gets run whenever a "logger reload" or "logger rotate" command is run. This results in logger_register_level printing error messages every time one of those commands is run because the custom level was already registered. You'll need to keep track of the previous value of "custom_levels" and unregister them all before registering the new custom_levels.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/dc6aabcf_282fe9ba">Patch Set #8, Line 2478:</a> <code style="font-family:monospace,monospace"> AST_RWLIST_UNLOCK(&logchannels);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can't unlock here because you moved the LOCK out.<br>If you leave this here, a deadlock will result.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/ad0d07c1_a5a21987">Patch Set #8, Line 2488:</a> <code style="font-family:monospace,monospace"> AST_RWLIST_UNLOCK(&logchannels);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16222/comment/bb6b15e5_fb73d01a">Patch Set #8, Line 2513:</a> <code style="font-family:monospace,monospace">ast_logger_dynamic_level</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_logger_get_dynamic_level</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16222">change 16222</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16222"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702 </div>
<div style="display:none"> Gerrit-Change-Number: 16222 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 24 Aug 2021 14:32:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>