<p> Attention is currently required from: N A. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16234">View Change</a></p><p>8 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_tonedetect.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/ab95373e_63126b86">Patch Set #3, Line 235:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       if (audiohook->status == AST_AUDIOHOOK_STATUS_DONE)<br>                return 0;<br><br>   /* Grab datastore which contains our gain information */<br>      if (!(datastore = ast_channel_datastore_find(chan, &detect_datastore, NULL)))<br>             return 0;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add braces to if blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/24d732d9_98510cba">Patch Set #3, Line 244:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    if (!frame || frame->frametype != AST_FRAME_VOICE)<br>         return 0;<br><br>   if (!(direction == AST_AUDIOHOOK_DIRECTION_READ ? &di->rx : &di->tx))<br>           return 0;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add braces to if block</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/a0e1c40e_53d7b697">Patch Set #3, Line 372:</a> <code style="font-family:monospace,monospace">  size = sizeof(context) + sizeof(exten) + sizeof(pri) + 2;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/sizeof/strlen</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also comment says "+ 1 for null terminator + 2 commas" so should this be + 3?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/92fc2c78_b2bfddcf">Patch Set #3, Line 373:</a> <code style="font-family:monospace,monospace">   dest = ast_malloc(size + 1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a NULL check here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/2599f6c2_93b14112">Patch Set #3, Line 460:</a> <code style="font-family:monospace,monospace">                   return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unlock channel before returning</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/99549cbc_f87bf1a2">Patch Set #3, Line 463:</a> <code style="font-family:monospace,monospace">                     return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unlock channel before returning</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/2a0a8ce3_06d5eaa5">Patch Set #3, Line 469:</a> <code style="font-family:monospace,monospace">                     return -1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Free the datastore and unlock channel before returning</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16234/comment/03a17348_f54e42cd">Patch Set #3, Line 618:</a> <code style="font-family:monospace,monospace">                     }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">frame needs to be freed once done.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16234">change 16234</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16234"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26 </div>
<div style="display:none"> Gerrit-Change-Number: 16234 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 19 Aug 2021 19:45:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>