<p> Attention is currently required from: Joshua Colp, Kevin Harwell. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16233">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File main/media_cache.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16233/comment/6fe398b3_b0afd2c9">Patch Set #2, Line 210:</a> <code style="font-family:monospace,monospace">        bucket_file = ao2_find(media_cache, uri, OBJ_SEARCH_KEY | OBJ_NOLOCK);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This logic doesn't appear to be correct. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You're right Joshua. Sorry for this, I got a bit confused and messed up.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Just pushed a new version to address your comments.<br>Basically using a new tmp_bucket_file pointer just to test if the file is already cached.<br>If it is, we just remove downloaded file, all refs and return.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If it doesn't exist, we just store the previously fetched bucket_file.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16233/comment/bf4e40bd_8bd4d6b3">Patch Set #2, Line 212:</a> <code style="font-family:monospace,monospace">           ao2_ref(bucket_file, -1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">As well when this logic is fixed - I believe you need to call ast_bucket_file_delete on what was ret […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just added that on the new patch.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks for your comments.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16233">change 16233</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16233"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408 </div>
<div style="display:none"> Gerrit-Change-Number: 16233 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 17 Aug 2021 20:36:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>