<p> Attention is currently required from: Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/15985">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_dial.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15985/comment/ef205198_5a68b86b">Patch Set #2, Line 1802:</a> <code style="font-family:monospace,monospace">                                           if (ast_check_hangup_locked(o->chan)) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">o->chan is an app_dial thing, it only exists in it. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I guess I mean the chan that o->chan is, not o->chan itself.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Interestingly, if I include this in the first big AST_LIST_TRAVERSE, it doesn't execute, however if I include it in the 2nd, it properly catches a dead channel:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (ast_check_hangup_locked(o->chan)) {<br>     ast_log(LOG_WARNING, "!!! Should be dead, but we're not?\n");<br>   continue;<br>}</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Isn't this what's supposed to tell the channel to hang up? There's a soft hangup queued, which reliably lets us know, even though the standard o->chan == NULL and f == NULL checks fail (that is, mislead us into thinking the channel is still up).</p><p style="white-space: pre-wrap; word-wrap: break-word;">What's the issue with this approach, that it's not app_dial's responsibility to check if a soft hangup is queued? I see other apps doing this so I'm confused.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15985">change 15985</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15985"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f2ee3f77b892015bc05513d868f071f279a3c80 </div>
<div style="display:none"> Gerrit-Change-Number: 15985 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 06 Aug 2021 22:34:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>