<p> Attention is currently required from: Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16075">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16075?tab=comments">Patch Set #4:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">No, the priority number itself doesn't matter. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">What you're saying sounds like it would work, but it also sounds like reinventing the wheel, and a big one at that.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Okay, that addresses the extensions (keys), somewhat - what about the lookups (values)? The dialplan needs to be able to handle and parse these like any other value.<br>I know I included a few examples with just static values, e.g.<br>exten => something,lookup,42<br>,but in practice, that's not as useful compared to things that are more dynamic. Fundamentally, it's a lookup of dialplan logic, hence why it fits so nicely in the dialplan.</p><p style="white-space: pre-wrap; word-wrap: break-word;">It doesn't make much sense why this should be any more foreign to the dialplan than this would be:</p><p style="white-space: pre-wrap; word-wrap: break-word;">[sub-lookup]<br>exten => _3XX,1,Return(42)<br>exten => _39X,1,Return(${SHELL(something)})<br>exten => _4XX,1,Return(${CURL(something)})<br>exten => _5XX/_50X,1,Return(999)<br>exten => _5XX/5XX,1,Return(888)<br>exten => _5XX,1,Gosub(some-other-sub,${CALLERID(num)},1)<br>same => n,Return(${GOSUB_RETVAL})<br>exten => _X!,1,Return()</p><p style="white-space: pre-wrap; word-wrap: break-word;">It makes no less sense to include a lookup context in the dialplan than that, it's just a context, albeit more elegant to use/manage.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16075">change 16075</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16075"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432 </div>
<div style="display:none"> Gerrit-Change-Number: 16075 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sarah Autumn <sarah@endlesstemple.org> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 19 Jul 2021 22:47:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>