<p> Attention is currently required from: Rijnhard Hessel. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16149">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/statsd.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16149/comment/ceaf238c_fec0e9ec">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace">/*! Events over time. Sorta like increment-only counters. */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"Metric types are non-standard and poorly supported by StatsD servers" […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_chan_stats.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16149/comment/0ed0083f_9e2c0bf7">Patch Set #1, Line 76:</a> <code style="font-family:monospace,monospace">         ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">it depends on the statsd server involved, which makes it complicated. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">We should avoid breaking existing functionality, for even a subset of users, if at all possible.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't know statsd at all so I can only speak in general policy perspective.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16149">change 16149</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16149"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7 </div>
<div style="display:none"> Gerrit-Change-Number: 16149 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Rijnhard Hessel <rijnhard@teleforge.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Rijnhard Hessel <rijnhard@teleforge.co.za> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Jul 2021 10:12:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Rijnhard Hessel <rijnhard@teleforge.co.za> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>