<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16084">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, approved; Approved for Submit
  George Joseph: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pbx_builtins: Corrects SayNumber warning<br><br>Previously, SayNumber always emitted a warning if the caller hung up<br>during execution. Usually this isn't correct, so check if the channel<br>hung up and, if so, don't emit a warning.<br><br>ASTERISK-29475<br><br>Change-Id: Ieea4a67301c6ea83bbc7690c1d4808d79a704594<br>---<br>M main/pbx_builtins.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/pbx_builtins.c b/main/pbx_builtins.c</span><br><span>index 7f76b97..e370338 100644</span><br><span>--- a/main/pbx_builtins.c</span><br><span>+++ b/main/pbx_builtins.c</span><br><span>@@ -1299,7 +1299,7 @@</span><br><span> </span><br><span>        res = ast_say_number(chan, number_val, interrupt ? AST_DIGIT_ANY : "", ast_channel_language(chan), options);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      if (res < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (res < 0 && !ast_check_hangup_locked(chan)) {</span><br><span>          ast_log(LOG_WARNING, "We were unable to say the number %s, is it too large?\n", tmp);</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16084">change 16084</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16084"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: Ieea4a67301c6ea83bbc7690c1d4808d79a704594 </div>
<div style="display:none"> Gerrit-Change-Number: 16084 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>