<p> Attention is currently required from: N A. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16041">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16041?tab=comments">Patch Set #2:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Going to need a test as well.  <br></p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_caller_id.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16041/comment/cf31317e_f815b607">Patch Set #2, Line 146:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                return ast_str_to_int(oli1->value.ptr, ani2);<br>      } else if ((oli2 = pjsip_param_find(&from_hdr->other_param, &oli_str2))) {<br>         return ast_str_to_int(oli2->value.ptr, ani2);<br>      } else if ((oli3 = pjsip_param_find(&from_hdr->other_param, &oli_str3))) {<br>         return ast_str_to_int(oli3->value.ptr, ani2);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can't use the pj_str_t ptr directly as a char * because it's not null terminated.  See the use of ast_copy_pj_str() set_id_from_header() above.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16041/comment/fd963d36_bb0de870">Patch Set #2, Line 407:</a> <code style="font-family:monospace,monospace">              struct ast_party_caller caller;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Other than initializing this, it doesn't look used.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16041/comment/9417c2d9_f795fe1f">Patch Set #2, Line 416:</a> <code style="font-family:monospace,monospace">                       ast_party_caller_init(&caller);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What's the purpose of this?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16041">change 16041</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16041"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifc938a7a7d45ce33999ebf3656a542226f6d3847 </div>
<div style="display:none"> Gerrit-Change-Number: 16041 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 09 Jun 2021 13:51:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>