<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15764">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c">File res/res_pjsip_outbound_authenticator_digest.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@220">Patch Set #6, Line 220:</a> <code style="font-family:monospace,monospace"> * about dupplicate realms until then.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">a duplicate p appears!</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@331">Patch Set #6, Line 331:</a> <code style="font-family:monospace,monospace"> * structure contents to the array element.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this should be extended to state that the auth_cred structure contents may still contain pointers, which are also copied. (auth_cred.username, auth_cred.data) but they are guaranteed to remain valid.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@372">Patch Set #6, Line 372:</a> <code style="font-family:monospace,monospace"> creds_array = AST_VECTOR_STEAL_ELEMENTS(&auth_creds);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">THIEF!</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@461">Patch Set #6, Line 461:</a> <code style="font-family:monospace,monospace"> goto cleanup;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">auth_sess may be uninitialized at this point if you jump to cleanup</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15764">change 15764</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15764"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I3aef5ce4fe1d27e48d61268520f284d15d650281 </div>
<div style="display:none"> Gerrit-Change-Number: 15764 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 May 2021 13:48:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>