<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15822">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken.c">File res/res_stir_shaken.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken.c@563">Patch Set #2, Line 563:</a> <code style="font-family:monospace,monospace"> * \retval full path filename on success</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Document that the caller has to free filename</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken.c@598">Patch Set #2, Line 598:</a> <code style="font-family:monospace,monospace"> * \retval full path filename on success</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/curl.h">File res/res_stir_shaken/curl.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/curl.h@69">Patch Set #2, Line 69:</a> <code style="font-family:monospace,monospace"> * \retval full path filename on success</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The lifetime of this should be documented, specifically that the caller has to free it</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/curl.c">File res/res_stir_shaken/curl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/curl.c@197">Patch Set #2, Line 197:</a> <code style="font-family:monospace,monospace"> ast_sha1_hash(hash, public_key_url);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this actually used any longer?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/stir_shaken.h">File res/res_stir_shaken/stir_shaken.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/stir_shaken.h@61">Patch Set #2, Line 61:</a> <code style="font-family:monospace,monospace"> * \retval serial number on success</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Caller must free it</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/stir_shaken.c">File res/res_stir_shaken/stir_shaken.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/stir_shaken.c@113">Patch Set #2, Line 113:</a> <code style="font-family:monospace,monospace"> key = X509_get_pubkey(cert);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this safe to do with the cert being freed below? If so, can it be documented as such?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/stir_shaken.c@167">Patch Set #2, Line 167:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_ERROR, "Failed to convert serial to bignum\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should include the certificate</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/stir_shaken.c@173">Patch Set #2, Line 173:</a> <code style="font-family:monospace,monospace"> serial_hex = BN_bn2hex(bignum);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Document how the memory for this works</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15822/2/res/res_stir_shaken/stir_shaken.c@179">Patch Set #2, Line 179:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_ERROR, "Failed to convert bignum to hex\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should include the certificate</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15822">change 15822</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15822"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ia00b20835f5f976e3603797f2f2fb19672d8114d </div>
<div style="display:none"> Gerrit-Change-Number: 15822 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Apr 2021 09:54:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>