<p><a href="https://gerrit.asterisk.org/c/asterisk/+/15445">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15445/1/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15445/1/res/res_pjsip_session.c@2405">Patch Set #1, Line 2405:</a> <code style="font-family:monospace,monospace">                 if (session->active_media_state->topology) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This check requires that session->active_media_state->topology be present which, of course, means that session->active_media_state must be non-NULL.   Now see below...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15445/1/res/res_pjsip_session.c@2445">Patch Set #1, Line 2445:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if this re-invite was the result of a requested topology<br>                               * change.  If it was the result of some other change, like connected line, then<br>                               * we don't want to suppress it even though the topologies are equal.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">We should remove this comment if it no longer applies.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15445/1/res/res_pjsip_session.c@2449">Patch Set #1, Line 2449:</a> <code style="font-family:monospace,monospace">                            if ((topology_change_request || session->active_media_state) && ast_stream_topology_equal(session->active_media_state->topology, pending_media_state->topology)) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">As far as connected line updates go, I ran an attended_transfer testsuite test with and without this […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's possible that I'm looking at it wrong but...  We're still inside the block that requires that session->active_media_state be non-NULL.  In turn, doesn't that mean that "(topology_change_request || session->active_media_state)" will always be true?  If so, you can just remove that extra predicate and just use ast_stream_topology_equal to determine if we should bail at this point.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15445">change 15445</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15445"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I04dc91befb2387904e28a9aaeaa3bcdbcaa7fa63 </div>
<div style="display:none"> Gerrit-Change-Number: 15445 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-CC: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 19 Feb 2021 13:45:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Comment-In-Reply-To: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>