<p><a href="https://gerrit.asterisk.org/c/asterisk/+/15195">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15195?tab=comments">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Is ao2_bump() safe to use in this case?  Here's what we're proposing for the channel reference:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    chan = ao2_bump(session->channel);<br>    if (!chan) {<br>        /* If there is no channel, terminate the subscription and release the session */<br>        pjsip_evsub_terminate(sub, PJ_FALSE);<br>        ao2_cleanup(session);<br>        return;<br>    }<br>    ...<br>    if (res) {<br>        ast_queue_control_data(chan, AST_CONTROL_TRANSFER, &message, sizeof(message));<br>        ao2_cleanup(session);<br>    }<br>    ...<br>    ao2_cleanup(chan);<br></pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15195">change 15195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I3fd92fd14b4e3844d3d7b0f60fe417a4df5f2435 </div>
<div style="display:none"> Gerrit-Change-Number: 15195 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Dan Cropp <dan@amtelco.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 14 Dec 2020 20:51:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>