<p style="white-space: pre-wrap; word-wrap: break-word;">Looks good other than the issue I mention below. Not sure how this got missed in the original implementation.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14940">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14940/2/res/res_musiconhold.c">File res/res_musiconhold.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14940/2/res/res_musiconhold.c@1612">Patch Set #2, Line 1612:</a> <code style="font-family:monospace,monospace">                      struct ast_config *entries = ast_load_realtime_multientry("musiconhold_entry", "name", name, SENTINEL);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So the 'position' column is part of the musiconhold_entry table's PK so I assume most databases will do the right thing, but to be sure you can change this to:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> struct ast_config *entries = ast_load_realtime_multientry(<br>    "musiconhold_entry",<br>    "position >=", "0",<br>    "name", name,<br>    SENTINEL);</pre><p style="white-space: pre-wrap; word-wrap: break-word;">This will result in the following query (note the 'ORDER BY'):</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> SELECT * FROM musiconhold_entry WHERE position >= ? AND name = ? ORDER BY position</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14940">change 14940</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14940"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I45636679c0fb5a5f59114c8741626631a604e8a6 </div>
<div style="display:none"> Gerrit-Change-Number: 14940 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lvl <digium@lvlconsultancy.nl> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 28 Sep 2020 14:38:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>