<p>Dovid Bender has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14900">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Mofified funcs/func_curl.c so that 404's are handled as a failure<br><br>Change-Id: Ib10e14ce240e8ceb659da63ea11b1d91ce6b179a<br>---<br>M funcs/func_curl.c<br>1 file changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/00/14900/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/funcs/func_curl.c b/funcs/func_curl.c</span><br><span>index 3e09d1c..16d4a1c 100644</span><br><span>--- a/funcs/func_curl.c</span><br><span>+++ b/funcs/func_curl.c</span><br><span>@@ -655,7 +655,8 @@</span><br><span> static int acf_curl_helper(struct ast_channel *chan, struct curl_args *args)</span><br><span> {</span><br><span>       struct ast_str *escapebuf = ast_str_thread_get(&thread_escapebuf, 16);</span><br><span style="color: hsl(0, 100%, 40%);">-      int ret = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ int ret = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+  long http_code = 0;     </span><br><span>     CURL **curl;</span><br><span>         struct curl_settings *cur;</span><br><span>   struct curl_slist *headers = NULL;</span><br><span>@@ -739,6 +740,13 @@</span><br><span>     * CURLOPT_ERRORBUFFER" (62bcf005f4678a93158358265ba905bace33b834). */</span><br><span>  curl_easy_setopt(*curl, CURLOPT_ERRORBUFFER, (char*)NULL);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        curl_easy_getinfo (*curl, CURLINFO_RESPONSE_CODE, &http_code);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if (http_code == 404){</span><br><span style="color: hsl(120, 100%, 40%);">+                ast_log(LOG_NOTICE, "Curl CURLINFO_RESPONSE_CODE (%ld).\n",http_code);</span><br><span style="color: hsl(120, 100%, 40%);">+              ret=-1;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (store) {</span><br><span>                 AST_LIST_UNLOCK(list);</span><br><span>       }</span><br><span>@@ -774,7 +782,6 @@</span><br><span>                      ast_free(fields);</span><br><span>                    ast_free(values);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               ret = 0;</span><br><span>     }</span><br><span> </span><br><span>        if (chan) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14900">change 14900</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14900"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib10e14ce240e8ceb659da63ea11b1d91ce6b179a </div>
<div style="display:none"> Gerrit-Change-Number: 14900 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Dovid Bender <dovid@telecurve.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>