<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14629">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14629/2/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14629/2/configs/samples/pjsip.conf.sample@850">Patch Set #2, Line 850:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ; operation: <intersect | only_preferred<br> ; | only_nonpreferred>,<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think the operation in this case would only allow "intersect". We'd never pass a codec along that's not in both lists (pending and configured). For instance if pending has alaw,ulaw, and configured has alaw,g722 then I don't think there is a reason to ever pass along ulaw or g722.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14629/2/configs/samples/pjsip.conf.sample@863">Patch Set #2, Line 863:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ; operation: <intersect | union<br> ; | only_preferred | only_nonpreferred>,<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Similar here. I don't think we'd pass codecs along that are not in both lists. It seems possible by setting only_preferred, or only_nonpreferred that could occur. For instance if pending has alaw,ulaw and configured has alaw,g722 and if prefer: pending, operation: only_preferred then alaw,ulaw are sent in the outgoing sdp which I don't think is correct. Unless I am misunderstanding.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I think "union" here could cause similar (as I understand union to be everything in set A + everything in set B). If pending has codecs not in configured those should be removed from the joint list, and not included.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14629/2/configs/samples/pjsip.conf.sample@867">Patch Set #2, Line 867:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">;incoming_answer_codec_prefs=; This is a string that describes how the codecs<br> ; specified in an incoming SDP answer (pending)<br> ; are reconciled with the codecs specified on an<br> ; endpoint (configured) when receiving an SDP<br> ; answer.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would have expected this option to relate to the answer sent in response to an incoming offer? To me "incoming" relates to the incoming side of a call from an Asterisk perspective.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14629/2/configs/samples/pjsip.conf.sample@879">Patch Set #2, Line 879:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">;outgoing_answer_codec_prefs=; This is a string that describes how the codecs<br> ; that come from the core (pending) are reconciled<br> ; with the codecs specified on an endpoint<br> ; (configured) when sending an SDP answer.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Similar, I would expect this to relate to the outgoing side of the call's answer. Seems like this description would be for "incoming_answer_codec_prefs" and those here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14629">change 14629</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14629"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I920ba925d7dd36430dfd2ebd9d82d23f123d0e11 </div>
<div style="display:none"> Gerrit-Change-Number: 14629 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Jul 2020 20:37:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>