<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14598">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_sip: chan_sip does not process 400 response to an INVITE.<br><br>chan_sip handle_response() function, for a 400 response to an INVITE,<br>calls handle_response_invite() and does not generate ACK.<br>handle_response_invite() does not recognize 400 response and has no<br>default response processing for unexpected responses, thus it does not<br>generate ACK either.<br>The ACK on response repetition comes from handle_response() mechanism<br>"We must re-send ACKs to re-transmitted final responses".<br><br>According to code history, 400 response specific processing was<br>introduced with commit<br>"channels/chan_sip: Add improved support for 4xx error codes"<br>This commit added support for :<br>- 400/414/493 in handle_response_subscribe() handle_response_register()<br>  and handle_response().<br>- 414/493 only in handle_response_invite().<br><br>This fix adds 400 response support in handle_response_invite().<br><br>ASTERISK-28957<br><br>Change-Id: Ic71a087e5398dfc7273946b9ec6f9a36960218ad<br>---<br>M channels/chan_sip.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_sip.c b/channels/chan_sip.c</span><br><span>index edb08e9..c67081c 100644</span><br><span>--- a/channels/chan_sip.c</span><br><span>+++ b/channels/chan_sip.c</span><br><span>@@ -24194,6 +24194,7 @@</span><br><span>          }</span><br><span>            break;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    case 400: /* Bad Request */</span><br><span>  case 414: /* Bad request URI */</span><br><span>      case 493: /* Undecipherable */</span><br><span>       case 404: /* Not found */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14598">change 14598</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14598"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Ic71a087e5398dfc7273946b9ec6f9a36960218ad </div>
<div style="display:none"> Gerrit-Change-Number: 14598 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>