<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14594">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_dadhi: Fix setvar in dahdi channels<br><br>The change to how setvar works for various channels performed in<br>ASTERISK~23756 missed some required change in the dahdi channel,<br>where the variables are actually set while reading configuration.<br>This change should fix the issue.<br><br>ASTERISK-28955<br><br>Change-Id: Ibfeb7f8cbdd735346dc4028de6a265f24f9df274<br>---<br>M channels/chan_dahdi.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c</span><br><span>index e885821..8d5d689 100644</span><br><span>--- a/channels/chan_dahdi.c</span><br><span>+++ b/channels/chan_dahdi.c</span><br><span>@@ -18140,8 +18140,10 @@</span><br><span>                           if ((varval = strchr(varname, '='))) {</span><br><span>                                       *varval++ = '\0';</span><br><span>                                    if ((tmpvar = ast_variable_new(varname, varval, ""))) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                               tmpvar->next = confp->chan.vars;</span><br><span style="color: hsl(0, 100%, 40%);">-                                          confp->chan.vars = tmpvar;</span><br><span style="color: hsl(120, 100%, 40%);">+                                         if (ast_variable_list_replace(&confp->chan.vars, tmpvar)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                                    tmpvar->next = confp->chan.vars;</span><br><span style="color: hsl(120, 100%, 40%);">+                                                        confp->chan.vars = tmpvar;</span><br><span style="color: hsl(120, 100%, 40%);">+                                         }</span><br><span>                                    }</span><br><span>                            }</span><br><span>                    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14594">change 14594</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14594"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: Ibfeb7f8cbdd735346dc4028de6a265f24f9df274 </div>
<div style="display:none"> Gerrit-Change-Number: 14594 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Guido Falsi <madpilot@freebsd.org> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Guido Falsi <madpilot@freebsd.org> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>