<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14509">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14509/2/res/res_pjsip_stir_shaken.c">File res/res_pjsip_stir_shaken.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14509/2/res/res_pjsip_stir_shaken.c@234">Patch Set #2, Line 234:</a> <code style="font-family:monospace,monospace">     encoded_header = ast_base64encode_string(ast_json_dump_string(header));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Memory leak here. ast_json_dump_string's return value must be freed using ast_json_free.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14509/2/res/res_pjsip_stir_shaken.c@241">Patch Set #2, Line 241:</a> <code style="font-family:monospace,monospace">  encoded_payload = ast_base64encode_string(ast_json_dump_string(payload));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same for this too. Result of dump string is leaked.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14509/2/res/res_pjsip_stir_shaken.c@253">Patch Set #2, Line 253:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    combined_size = strlen(encoded_header) + 1 + strlen(encoded_payload) + 1<br>              + strlen(signature) + strlen(";info=<>alg=;ppt=") + strlen(public_key_url)<br>            + strlen(STIR_SHAKEN_ENCRYPTION_ALGORITHM) + strlen(STIR_SHAKEN_PPT) + 1;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you can remove all the +1's except the last one here as you only need one for the final  null terminator.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14509">change 14509</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14509"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1f84d6a5839cb2ed152ef4255b380cfc2de662b4 </div>
<div style="display:none"> Gerrit-Change-Number: 14509 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 15 Jun 2020 22:44:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>