<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14483">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Kevin Harwell: Looks good to me, approved
  George Joseph: Looks good to me, but someone else must approve
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_fax: Don't consume frames given to fax gateway on write.<br><br>In a particular fax gateway scenario whereby it would<br>have to translate using the read translation path on a<br>channel the frame being translated would be consumed.<br>When the frame is in the write path it is not permitted<br>to free the frame as the caller expects it to continue<br>to exist.<br><br>This change makes it so that the frame is only consumed<br>on the read path where it is acceptable to free it.<br><br>ASTERISK-28900<br><br>Change-Id: I011c321288a1b056d92b37c85e229f4a28ee737d<br>---<br>M res/res_fax.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_fax.c b/res/res_fax.c</span><br><span>index ebb2b46..b895c57 100644</span><br><span>--- a/res/res_fax.c</span><br><span>+++ b/res/res_fax.c</span><br><span>@@ -3568,7 +3568,7 @@</span><br><span>                 * translation is done, so we need to translate here */</span><br><span>              if ((f->frametype == AST_FRAME_VOICE) && (ast_format_cmp(f->subclass.format, ast_format_slin) != AST_FORMAT_CMP_EQUAL)</span><br><span>                         && (readtrans = ast_channel_readtrans(active))) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       if ((f = ast_translate(readtrans, f, 1)) == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   if ((f = ast_translate(readtrans, f, event == AST_FRAMEHOOK_EVENT_WRITE ? 0 : 1)) == NULL) {</span><br><span>                                 f = &ast_null_frame;</span><br><span>                             return f;</span><br><span>                    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14483">change 14483</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14483"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: I011c321288a1b056d92b37c85e229f4a28ee737d </div>
<div style="display:none"> Gerrit-Change-Number: 14483 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>