<p>Nicholas John Koch has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14409">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_musiconhold: Performance improvement of bug fix<br><br>ASTERISK-28892<br>Reported-By: Nicholas John Koch<br><br>Change-Id: I91e37023b1c578a3fb307acb476204599a25f31f<br>---<br>M res/res_musiconhold.c<br>1 file changed, 3 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/09/14409/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_musiconhold.c b/res/res_musiconhold.c</span><br><span>index c2eb1ac..01a14b9 100644</span><br><span>--- a/res/res_musiconhold.c</span><br><span>+++ b/res/res_musiconhold.c</span><br><span>@@ -1091,11 +1091,9 @@</span><br><span>                              if (ast_begins_with(dup, "/")) {</span><br><span>                                   char *last_pos_dot = strrchr(dup, '.');</span><br><span>                                      char *last_pos_slash = strrchr(dup, '/');</span><br><span style="color: hsl(0, 100%, 40%);">-                                       if (last_pos_dot != NULL) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                             if ((int)(last_pos_dot - dup) > (int)(last_pos_slash - dup)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                                       ast_log(LOG_WARNING, "The playlist entry '%s' may include an extension, which could prevent it from playing.\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                                                              dup);</span><br><span style="color: hsl(0, 100%, 40%);">-                                           }</span><br><span style="color: hsl(120, 100%, 40%);">+                                     if (last_pos_dot && last_pos_dot > last_pos_slash) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                               ast_log(LOG_WARNING, "The playlist entry '%s' may include an extension, which could prevent it from playing.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                                    dup);</span><br><span>                                        }</span><br><span>                            }</span><br><span>                            AST_VECTOR_APPEND(&mohclass->files, dup);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14409">change 14409</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14409"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I91e37023b1c578a3fb307acb476204599a25f31f </div>
<div style="display:none"> Gerrit-Change-Number: 14409 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nicholas John Koch <koch@njk-it.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>