<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;"><br>This seems an appealing middle ground to me, is there a consensus that this would be acceptable?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> </pre></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Gerrit didn't give my prior comment the context I thought it would, so to clarify it was in response to:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe we could use __ast_assert_failed here instead?  In normal production builds (without DO_CRASH) this would log a frack and backtrace instead of crashing.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I think that is acceptable, but ultimately a backtrace would be needed for long term fix.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14144">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14144">change 14144</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14144"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I3393e4d521ab6c4551b5434d013a5941706c28de </div>
<div style="display:none"> Gerrit-Change-Number: 14144 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Robert Sutton <rsutton@noojee.com.au> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 May 2020 10:35:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>