<p><a href="https://gerrit.asterisk.org/c/asterisk/+/14328">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14328/3/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14328/3/configs/samples/pjsip.conf.sample@875">Patch Set #3, Line 875:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ; remote - Include all codecs in the remote list that<br> ; are also in the local list preserving remote list<br> ; order. (default)<br> ; remote_merge - Include all codecs in BOTH lists<br> ; preserving the remote list order. Codes in the<br> ; local list not in the remote list will be placed<br> ; at the end of the joint list.<br> ; remote_first - Include only the first codec in<br> ; the remote list.<br></pre></blockquote></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">The wiki page defines the incoming_call_answer_pref option as having options which take into account the answer from the callee/called party. I don't think this is currently done, or at least I can not see where the information is communicated back and used.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">The wording is kinda funny and unfortunately there's not enough room here to fully describe what's going on. In this case, "remote" is Bob and his incoming answer was already resolved against his pending topology using outgoing_call_answer_pref (apply_negotiated_sdp_stream calls set_caps). So what's passed to the core is the resolved list. Alice's answer is created by resolving her pending topology with what came from the core (remote). </p><p style="white-space: pre-wrap; word-wrap: break-word;">Of course it's always possible I missed something but I've been auditing the process with debug statements. Now that we can process a round-trip call, more tests are possible.</p><p style="white-space: pre-wrap; word-wrap: break-word;">We'll need more/corrected documentation after the refactor.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14328/3/include/asterisk/res_pjsip_session.h">File include/asterisk/res_pjsip_session.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14328/3/include/asterisk/res_pjsip_session.h@933">Patch Set #3, Line 933:</a> <code style="font-family:monospace,monospace"> * @param session</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">We use \ everywhere else, why the use of @ here? Automagicness?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Oops, yeah I've been meaning to fix my Eclipse Doxygen templates for years. Maybe I'll get to it before I due. Will fix.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14328/3/include/asterisk/res_pjsip_session.h@936">Patch Set #3, Line 936:</a> <code style="font-family:monospace,monospace">const char *ast_sip_session_get_name(struct ast_sip_session *session);</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Should the session be const as well?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Good point. Will fix.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14328">change 14328</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14328"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iad188ae997bdcb5c28e2eb12c6bb2b732538ad45 </div>
<div style="display:none"> Gerrit-Change-Number: 14328 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 May 2020 13:29:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>