<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14220">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken.c">File res/res_stir_shaken.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken.c@193">Patch Set #5, Line 193:</a> <code style="font-family:monospace,monospace"> * \brief Add the public key and its file path to AstDB</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This isn't actually true. You're adding the public key details, not the key itself.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken.c@209">Patch Set #5, Line 209:</a> <code style="font-family:monospace,monospace"> * \brief Remove the public key and associated information from AstDB</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ditto here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken.c@269">Patch Set #5, Line 269:</a> <code style="font-family:monospace,monospace">    if (signature[signature_length - 1] == '=') {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If someone passed in a short signature this would be sad.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken.c@414">Patch Set #5, Line 414:</a> <code style="font-family:monospace,monospace">                     ast_log(LOG_ERROR, "Newly downloaded public key '%s' is expired\n", file_path);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does it make sense to do the expiration check if we just downloaded the file?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken.c@438">Patch Set #5, Line 438:</a> <code style="font-family:monospace,monospace">             ast_debug(3, "Failed first read of public key file '%s'\n", file_path);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is there any way to combine all these logical blocks or reduce code duplication?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken/curl.c">File res/res_stir_shaken/curl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14220/5/res/res_stir_shaken/curl.c@31">Patch Set #5, Line 31:</a> <code style="font-family:monospace,monospace">#define CURL_TIMEOUT_SEC 7</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this should be configurable, and default to shorter</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14220">change 14220</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14220"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3ba4c63880493bf8c7d17a9cfca1af0e934d1a1c </div>
<div style="display:none"> Gerrit-Change-Number: 14220 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Apr 2020 09:43:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>