<p style="white-space: pre-wrap; word-wrap: break-word;">Fixed it. 😊</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14279">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c">File res/ari/resource_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c@1119">Patch Set #2, Line 1119:</a> <code style="font-family:monospace,monospace"> dialdevice = ast_strdupa(stuff);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Rather than allocating and copying the data. Just assign dialdevice with stuff. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Good, I agree with this too.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c@1829">Patch Set #2, Line 1829:</a> <code style="font-family:monospace,monospace"> dialdevice = ast_strdupa(stuff);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">same here […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Np, fixed it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c@1832">Patch Set #2, Line 1832:</a> <code style="font-family:monospace,monospace"> originator = ast_channel_get_by_name(args->originator);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Missing a sanity check before this line just like in ari_channels_handle_originate_with_id(). […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Indeed. Fixed it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">And added sanity checks, this will prevent the NULL string use in the save_dialstring().</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14279">change 14279</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14279"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I91b5f6708a1200363f3267b847dd6a0915222c25 </div>
<div style="display:none"> Gerrit-Change-Number: 14279 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 22 Apr 2020 09:12:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>