<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14279">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c">File res/ari/resource_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c@1119">Patch Set #2, Line 1119:</a> <code style="font-family:monospace,monospace">           dialdevice = ast_strdupa(stuff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Rather than allocating and copying the data.  Just assign dialdevice with stuff.<br>dialdevice = stuff;</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c@1829">Patch Set #2, Line 1829:</a> <code style="font-family:monospace,monospace">              dialdevice = ast_strdupa(stuff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same here<br>dialdevice = stuff;</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14279/2/res/ari/resource_channels.c@1832">Patch Set #2, Line 1832:</a> <code style="font-family:monospace,monospace">     originator = ast_channel_get_by_name(args->originator);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Missing a sanity check before this line just like in ari_channels_handle_originate_with_id().  We need to check if dialtech or dialdevice is not ast_strlen_zero() and return similar error as the args->endpoint check above.  Error message something like: "Invalid endpoint specified".</p><p style="white-space: pre-wrap; word-wrap: break-word;">I think the use of stuff later to save_dialstring() will crash if there is no '/' found in the args->endpoint.  (stuff would be NULL)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14279">change 14279</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14279"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I91b5f6708a1200363f3267b847dd6a0915222c25 </div>
<div style="display:none"> Gerrit-Change-Number: 14279 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 21 Apr 2020 20:49:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>