<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/14077">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Benjamin Keith Ford: Looks good to me, but someone else must approve
Friendly Automation: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjsip/sdp_offer_answer/attribute_passthrough: Fix XML regexes<br><br>The regex in phone_B_h264.xml was passing when it shouldn't have<br>been because of missing parentheses.<br><br>The regexes in phone_A_speex.xml and phone_B_speex.xml were also<br>passing when they shouldn't have been because "check_it" was set to<br>"false" instead of "check_it_inverse" being set to "true".<br><br>Change-Id: I1537249b6f25b12dfd5d5ea74edf9fee7b7e9d26<br>---<br>M tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml<br>M tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml<br>M tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml<br>4 files changed, 3 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf</span><br><span>index a2d4d92..5598d0d 100644</span><br><span>--- a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf</span><br><span>@@ -36,7 +36,6 @@</span><br><span> contact=sip:127.0.0.3:5063</span><br><span> </span><br><span> [phoneB-h264](endpoint-template)</span><br><span style="color: hsl(0, 100%, 40%);">-type=endpoint</span><br><span> aors=phoneB-h264</span><br><span> disallow=all</span><br><span> allow=ulaw</span><br><span>@@ -47,7 +46,6 @@</span><br><span> contact=sip:127.0.0.3:5064</span><br><span> </span><br><span> [phoneB-speex](endpoint-template)</span><br><span style="color: hsl(0, 100%, 40%);">-type=peer</span><br><span> aors=phoneB-speex</span><br><span> disallow=all</span><br><span> allow=ulaw</span><br><span>diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml</span><br><span>index 98805ac..f2adbfb 100644</span><br><span>--- a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml</span><br><span>+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml</span><br><span>@@ -44,7 +44,7 @@</span><br><span> <recv response="200" rtd="true"></span><br><span> <action></span><br><span> <ereg regexp="a=fmtp:99 sr=8000,mode=any"</span><br><span style="color: hsl(0, 100%, 40%);">- search_in="body" check_it="false" assign_to="1"/></span><br><span style="color: hsl(120, 100%, 40%);">+ search_in="body" check_it_inverse="true" assign_to="1"/></span><br><span> <strcmp assign_to="1" variable="1" value=""/></span><br><span> </action></span><br><span> </recv></span><br><span>diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml</span><br><span>index 5af8629..c203b01 100644</span><br><span>--- a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml</span><br><span>+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml</span><br><span>@@ -11,7 +11,7 @@</span><br><span> search_in="hdr"</span><br><span> check_it="true"</span><br><span> assign_to="global_call_id"/></span><br><span style="color: hsl(0, 100%, 40%);">- <ereg regexp="m=video [0-9]{1,5} RTP/AVP( [0-9]{1,3})+..*a=rtpmap:9[6-9]|1{0,1}[0-9]|12[0-7] H264/90000.*a=fmtp:9[6-9]|1{0,1}[0-9]|12[0-7] max-mbps=48600;packetization-mode=1;profile-level-id=42801E"</span><br><span style="color: hsl(120, 100%, 40%);">+ <ereg regexp="m=video [0-9]{1,5} RTP/AVP( [0-9]{1,3})+..*a=rtpmap:(9[6-9]|1{0,1}[0-9]|12[0-7]) H264/90000.*a=fmtp:(9[6-9]|1{0,1}[0-9]|12[0-7]) max-mbps=48600;packetization-mode=1;profile-level-id=42801E"</span><br><span> search_in="body" check_it="true" assign_to="1"/></span><br><span> <strcmp assign_to="1" variable="1" value=""/></span><br><span> </span><br><span>diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml</span><br><span>index cc5b445..017e4ee 100644</span><br><span>--- a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml</span><br><span>+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml</span><br><span>@@ -12,7 +12,7 @@</span><br><span> check_it="true"</span><br><span> assign_to="global_call_id"/></span><br><span> <ereg regexp="a=fmtp:99 sr=8000,mode=any"</span><br><span style="color: hsl(0, 100%, 40%);">- search_in="body" check_it="false" assign_to="1"/></span><br><span style="color: hsl(120, 100%, 40%);">+ search_in="body" check_it_inverse="true" assign_to="1"/></span><br><span> <strcmp assign_to="1" variable="1" value=""/></span><br><span> </span><br><span> </action></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/14077">change 14077</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/14077"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: certified/16.3 </div>
<div style="display:none"> Gerrit-Change-Id: I1537249b6f25b12dfd5d5ea74edf9fee7b7e9d26 </div>
<div style="display:none"> Gerrit-Change-Number: 14077 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-MessageType: merged </div>