<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14065">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
George Joseph: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">dial.c: Removed dial string 80 character limitation<br><br>The dial application had 80 characters of destination length<br>limitation. But this limitation causes unexpected dial string<br>cut if the dial string is long.<br><br>Removed unnecessary limited buffer to support longer dial<br>destination.<br><br>ASTERISK-27946<br><br>Change-Id: I72c8f0319a4b47e8180817a66a7e9bde063cb330<br>---<br>M main/dial.c<br>1 file changed, 3 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/dial.c b/main/dial.c</span><br><span>index ffa4405..95a2499 100644</span><br><span>--- a/main/dial.c</span><br><span>+++ b/main/dial.c</span><br><span>@@ -292,7 +292,6 @@</span><br><span> /*! \brief Helper function that requests all channels */</span><br><span> static int begin_dial_prerun(struct ast_dial_channel *channel, struct ast_channel *chan, struct ast_format_cap *cap, const char *predial_string)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- char numsubst[AST_MAX_EXTENSION];</span><br><span> struct ast_format_cap *cap_all_audio = NULL;</span><br><span> struct ast_format_cap *cap_request;</span><br><span> struct ast_format_cap *requester_cap = NULL;</span><br><span>@@ -315,9 +314,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Copy device string over */</span><br><span style="color: hsl(0, 100%, 40%);">- ast_copy_string(numsubst, channel->device, sizeof(numsubst));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> if (cap && ast_format_cap_count(cap)) {</span><br><span> cap_request = cap;</span><br><span> } else if (requester_cap) {</span><br><span>@@ -329,7 +325,7 @@</span><br><span> }</span><br><span> </span><br><span> /* If we fail to create our owner channel bail out */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!(channel->owner = ast_request(channel->tech, cap_request, &assignedids, chan, numsubst, &channel->cause))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!(channel->owner = ast_request(channel->tech, cap_request, &assignedids, chan, channel->device, &channel->cause))) {</span><br><span> ao2_cleanup(cap_all_audio);</span><br><span> return -1;</span><br><span> }</span><br><span>@@ -413,7 +409,6 @@</span><br><span> /*! \brief Helper function that does the beginning dialing per-appended channel */</span><br><span> static int begin_dial_channel(struct ast_dial_channel *channel, struct ast_channel *chan, int async, const char *predial_string, struct ast_channel *forwarder_chan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- char numsubst[AST_MAX_EXTENSION];</span><br><span> int res = 1;</span><br><span> char forwarder[AST_CHANNEL_NAME];</span><br><span> </span><br><span>@@ -429,11 +424,8 @@</span><br><span> ast_channel_unlock(channel->owner);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Copy device string over */</span><br><span style="color: hsl(0, 100%, 40%);">- ast_copy_string(numsubst, channel->device, sizeof(numsubst));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Attempt to actually call this device */</span><br><span style="color: hsl(0, 100%, 40%);">- if ((res = ast_call(channel->owner, numsubst, 0))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if ((res = ast_call(channel->owner, channel->device, 0))) {</span><br><span> res = 0;</span><br><span> ast_hangup(channel->owner);</span><br><span> channel->owner = NULL;</span><br><span>@@ -443,7 +435,7 @@</span><br><span> }</span><br><span> ast_channel_publish_dial(async ? NULL : chan, channel->owner, channel->device, NULL);</span><br><span> res = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- ast_verb(3, "Called %s\n", numsubst);</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_verb(3, "Called %s\n", channel->device);</span><br><span> }</span><br><span> </span><br><span> return res;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14065">change 14065</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14065"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I72c8f0319a4b47e8180817a66a7e9bde063cb330 </div>
<div style="display:none"> Gerrit-Change-Number: 14065 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>